From fc20359fed5e3d0e89a60653b9b0d638d4d757d8 Mon Sep 17 00:00:00 2001 From: Mike Spreitzer Date: Mon, 12 Nov 2018 14:45:45 -0500 Subject: [PATCH] Clarified syntax doc on --watch-cache-sizes Noted that group must be omitted for resources of apiVersion v1 (the legacy core API) and included for others. Fixes #65393 --- staging/src/k8s.io/apiserver/pkg/server/options/etcd.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/staging/src/k8s.io/apiserver/pkg/server/options/etcd.go b/staging/src/k8s.io/apiserver/pkg/server/options/etcd.go index 7c2a08ba0ae..7cc220d3cfe 100644 --- a/staging/src/k8s.io/apiserver/pkg/server/options/etcd.go +++ b/staging/src/k8s.io/apiserver/pkg/server/options/etcd.go @@ -134,9 +134,10 @@ func (s *EtcdOptions) AddFlags(fs *pflag.FlagSet) { "Default watch cache size. If zero, watch cache will be disabled for resources that do not have a default watch size set.") fs.StringSliceVar(&s.WatchCacheSizes, "watch-cache-sizes", s.WatchCacheSizes, ""+ - "List of watch cache sizes for every resource (pods, nodes, etc.), comma separated. "+ - "The individual override format: resource[.group]#size, where resource is lowercase plural (no version), "+ - "group is optional, and size is a number. It takes effect when watch-cache is enabled. "+ + "Watch cache size settings for some resources (pods, nodes, etc.), comma separated. "+ + "The individual setting format: resource[.group]#size, where resource is lowercase plural (no version), "+ + "group is omitted for resources of apiVersion v1 (the legacy core API) and included for others, "+ + "and size is a number. It takes effect when watch-cache is enabled. "+ "Some resources (replicationcontrollers, endpoints, nodes, pods, services, apiservices.apiregistration.k8s.io) "+ "have system defaults set by heuristics, others default to default-watch-cache-size")