From a0d3cb0a2c749b9d9dc85636aee871c628ab767f Mon Sep 17 00:00:00 2001 From: vivzbansal Date: Thu, 7 Nov 2024 20:07:07 +0000 Subject: [PATCH] Added proper validation msg when non-sidecar containers are resized --- pkg/apis/core/validation/validation.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pkg/apis/core/validation/validation.go b/pkg/apis/core/validation/validation.go index 4ca9bba7f42..d51abf3c0e9 100644 --- a/pkg/apis/core/validation/validation.go +++ b/pkg/apis/core/validation/validation.go @@ -5665,6 +5665,13 @@ func ValidatePodResize(newPod, oldPod *core.Pod, opts PodValidationOptions) fiel newInitContainers = append(newInitContainers, container) } originalCPUMemPodSpec.InitContainers = newInitContainers + if !apiequality.Semantic.DeepEqual(originalCPUMemPodSpec.InitContainers, oldPod.Spec.InitContainers) { + // This likely means that the user has modified non-sidecar container resources. + specDiff := cmp.Diff(oldPod.Spec.InitContainers, originalCPUMemPodSpec.InitContainers) + errs := field.Forbidden(specPath, fmt.Sprintf("cpu and memory resources for only sidecar containers are mutable\n%v", specDiff)) + allErrs = append(allErrs, errs) + return allErrs + } } if !apiequality.Semantic.DeepEqual(originalCPUMemPodSpec, oldPod.Spec) {