From 78798f6191f22ff5f35476f2a11d4b8172bc29de Mon Sep 17 00:00:00 2001 From: Eric Paris Date: Mon, 5 Dec 2016 19:29:34 -0500 Subject: [PATCH] Remove girishkalele from most places This also updates the maintainers list and reassigns his tests --- hack/update_owners.py | 48 +++++++++++++++++------------------- pkg/api/service/OWNERS | 1 - pkg/proxy/healthcheck/OWNERS | 1 - test/test_owners.csv | 30 +++++++++++----------- 4 files changed, 38 insertions(+), 42 deletions(-) diff --git a/hack/update_owners.py b/hack/update_owners.py index e464ee509e6..f8807ed37da 100755 --- a/hack/update_owners.py +++ b/hack/update_owners.py @@ -94,24 +94,20 @@ def get_maintainers(): # Run this in the js console: # [].slice.call(document.querySelectorAll('.team-member-username a')).map( # e => e.textContent.trim()) - ret = {"a-robinson", "alex-mohr", "amygdala", "andyzheng0831", "apelisse", - "aronchick", "bgrant0607", "bgrant0607-nocc", "bprashanth", - "brendandburns", "caesarxuchao", "childsb", "cjcullen", - "david-mcmahon", "davidopp", "dchen1107", "deads2k", - "derekwaynecarr", "dubstack", "eparis", "erictune", "fabioy", - "fejta", "fgrzadkowski", "freehan", "ghodss", "girishkalele", - "gmarek", "goltermann", "grodrigues3", "hurf", "ingvagabund", "ixdy", - "jackgr", "janetkuo", "jbeda", "jdef", "jfrazelle", "jingxu97", - "jlowdermilk", "jsafrane", "jszczepkowski", "justinsb", "kargakis", - "karlkfi", "kelseyhightower", "kevin-wangzefeng", "krousey", - "lavalamp", "liggitt", "luxas", "madhusudancs", "maisem", "mansoorj", - "matchstick", "mbohlool", "mikedanese", "mml", "mtaufen", "mwielgus", - "ncdc", "nikhiljindal", "piosz", "pmorie", "pwittrock", "Q-Lee", - "quinton-hoole", "Random-Liu", "rmmh", "roberthbailey", "ronnielai", - "saad-ali", "sarahnovotny", "smarterclayton", "soltysh", "spxtr", - "sttts", "thockin", "timothysc", "timstclair", "tmrts", - "vishh", "vulpecula", "wojtek-t", "xiang90", "yifan-gu", "yujuhong", - "zmerlynn"} + ret = {"alex-mohr", "apelisse", "aronchick", "bgrant0607", "bgrant0607-nocc", + "bprashanth", "brendandburns", "caesarxuchao", "childsb", "cjcullen", + "david-mcmahon", "davidopp", "dchen1107", "deads2k", "derekwaynecarr", + "eparis", "erictune", "fabioy", "fejta", "fgrzadkowski", "freehan", + "gmarek", "grodrigues3", "ingvagabund", "ixdy", "janetkuo", "jbeda", + "jessfraz", "jingxu97", "jlowdermilk", "jsafrane", "jszczepkowski", + "justinsb", "kargakis", "Kashomon", "kevin-wangzefeng", "krousey", + "lavalamp", "liggitt", "luxas", "madhusudancs", "maisem", "matchstick", + "mbohlool", "mikedanese", "mml", "mtaufen", "mwielgus", "ncdc", + "nikhiljindal", "piosz", "pmorie", "pwittrock", "Q-Lee", "quinton-hoole", + "Random-Liu", "rmmh", "roberthbailey", "saad-ali", "smarterclayton", + "soltysh", "spxtr", "sttts", "thelinuxfoundation", "thockin", + "timothysc", "timstclair", "vishh", "wojtek-t", "xiang90", "yifan-gu", + "yujuhong", "zmerlynn"} return sorted(ret - SKIP_MAINTAINERS) @@ -128,6 +124,7 @@ def main(): parser = argparse.ArgumentParser() parser.add_argument('--history', action='store_true', help='Generate test list from result history.') parser.add_argument('--user', help='User to assign new tests to (or RANDOM, default: current GitHub user).') + parser.add_argument('--addonly', action='store_true', help='Only add missing tests, do not change existing.') parser.add_argument('--check', action='store_true', help='Exit with a nonzero status if the test list has changed.') options = parser.parse_args() @@ -163,13 +160,14 @@ def main(): for name in outdated_tests: owners.pop(name) - print '# UNEXPECTED MAINTAINERS ', - print '(randomly assigned, but not in kubernetes-maintainers)' - for name, (owner, random_assignment) in sorted(owners.iteritems()): - if random_assignment and owner not in maintainers: - print '%-16s %s' % (owner, name) - owners.pop(name) - print + if not options.addonly: + print '# UNEXPECTED MAINTAINERS ', + print '(randomly assigned, but not in kubernetes-maintainers)' + for name, (owner, random_assignment) in sorted(owners.iteritems()): + if random_assignment and owner not in maintainers: + print '%-16s %s' % (owner, name) + owners.pop(name) + print owner_counts = collections.Counter( owner for name, (owner, random) in owners.iteritems() diff --git a/pkg/api/service/OWNERS b/pkg/api/service/OWNERS index 1692d0ce126..f9627e5f732 100755 --- a/pkg/api/service/OWNERS +++ b/pkg/api/service/OWNERS @@ -1,5 +1,4 @@ reviewers: - justinsb -- girishkalele - freehan - david-mcmahon diff --git a/pkg/proxy/healthcheck/OWNERS b/pkg/proxy/healthcheck/OWNERS index a006fd89a03..0e4b22dce61 100755 --- a/pkg/proxy/healthcheck/OWNERS +++ b/pkg/proxy/healthcheck/OWNERS @@ -1,3 +1,2 @@ reviewers: -- girishkalele - m1093782566 diff --git a/test/test_owners.csv b/test/test_owners.csv index 751b4754b1e..62bd480dcde 100644 --- a/test/test_owners.csv +++ b/test/test_owners.csv @@ -1,6 +1,7 @@ name,owner,auto-assigned DEFAULT,rmmh/spxtr/ixdy/apelisse/fejta,0 Addon update should propagate add-on file changes,eparis,1 +AppArmor should enforce an AppArmor profile,kevin-wangzefeng,1 AppArmor when running with AppArmor should enforce a permissive profile,yujuhong,1 AppArmor when running with AppArmor should enforce a profile blocking writes,freehan,1 AppArmor when running with AppArmor should reject an unloaded profile,kargakis,1 @@ -123,7 +124,7 @@ Empty does nothing,cjcullen,1 "EmptyDir volumes should support (root,0666,tmpfs)",davidopp,1 "EmptyDir volumes should support (root,0777,default)",spxtr,1 "EmptyDir volumes should support (root,0777,tmpfs)",alex-mohr,1 -EmptyDir volumes volume on default medium should have the correct mode,girishkalele,1 +EmptyDir volumes volume on default medium should have the correct mode,yifan-gu,1 EmptyDir volumes volume on tmpfs should have the correct mode,mwielgus,1 "EmptyDir volumes when FSGroup is specified files with FSGroup ownership should support (root,0644,tmpfs)",justinsb,1 EmptyDir volumes when FSGroup is specified new files should be created with FSGroup ownership when container is non-root,brendandburns,1 @@ -131,7 +132,7 @@ EmptyDir volumes when FSGroup is specified new files should be created with FSGr EmptyDir volumes when FSGroup is specified volume on default medium should have the correct mode using FSGroup,eparis,1 EmptyDir volumes when FSGroup is specified volume on tmpfs should have the correct mode using FSGroup,timothysc,1 EmptyDir wrapper volumes should not cause race condition when used for configmaps,mtaufen,1 -EmptyDir wrapper volumes should not cause race condition when used for git_repo,girishkalele,1 +EmptyDir wrapper volumes should not cause race condition when used for git_repo,brendandburns,1 EmptyDir wrapper volumes should not conflict,deads2k,1 Etcd failure should recover from SIGKILL,pmorie,1 Etcd failure should recover from network partition with master,justinsb,1 @@ -357,7 +358,7 @@ Pods should support retrieving logs from the container over websockets,vishh,0 "Port forwarding With a server that expects a client request should support a client that connects, sends no data, and disconnects",sttts,0 "Port forwarding With a server that expects no client request should support a client that connects, sends no data, and disconnects",sttts,0 PreStop should call prestop when killing a pod,ncdc,1 -PrivilegedPod should test privileged pod,vishh,0 +PrivilegedPod should enable privileged commands,dchen1107,1 Probing container should *not* be restarted with a /healthz http liveness probe,Random-Liu,0 "Probing container should *not* be restarted with a exec ""cat /tmp/health"" liveness probe",Random-Liu,0 Probing container should be restarted with a /healthz http liveness probe,Random-Liu,0 @@ -404,7 +405,7 @@ SSH should SSH to all nodes and run commands,quinton-hoole,0 SchedulerPredicates validates MaxPods limit number of pods that are allowed to run,gmarek,0 SchedulerPredicates validates resource limits of pods that are allowed to run,gmarek,0 SchedulerPredicates validates that Inter-pod-Affinity is respected if not matching,hurf,1 -SchedulerPredicates validates that InterPod Affinity and AntiAffinity is respected if matching,girishkalele,1 +SchedulerPredicates validates that InterPod Affinity and AntiAffinity is respected if matching,yifan-gu,1 SchedulerPredicates validates that InterPodAffinity is respected if matching,kevin-wangzefeng,1 SchedulerPredicates validates that InterPodAffinity is respected if matching with multiple Affinities,caesarxuchao,1 SchedulerPredicates validates that InterPodAntiAffinity is respected if matching 2,sttts,0 @@ -425,7 +426,7 @@ Secrets should be consumable from pods in volume,ghodss,1 Secrets should be consumable from pods in volume with defaultMode set,derekwaynecarr,1 Secrets should be consumable from pods in volume with mappings,jbeda,1 Secrets should be consumable from pods in volume with mappings and Item Mode set,quinton-hoole,1 -Secrets should be consumable in multiple volumes in a pod,girishkalele,1 +Secrets should be consumable in multiple volumes in a pod,alex-mohr,1 Security Context should support container.SecurityContext.RunAsUser,alex-mohr,1 Security Context should support pod.Spec.SecurityContext.RunAsUser,bgrant0607,1 Security Context should support pod.Spec.SecurityContext.SupplementalGroups,andyzheng0831,1 @@ -456,13 +457,13 @@ Services should use same NodePort with same port but different protocols,timothy Services should work after restarting apiserver,bprashanth,0 Services should work after restarting kube-proxy,bprashanth,0 SimpleMount should be able to mount an emptydir on a container,karlkfi,1 -"Spark should start spark master, driver and workers",girishkalele,1 +"Spark should start spark master, driver and workers",jszczepkowski,1 "Staging client repo client should create pods, delete pods, watch pods",jbeda,1 Stateful Set recreate should recreate evicted statefulset,derekwaynecarr,0 StatefulSet Basic StatefulSet functionality Scaling down before scale up is finished should wait until current pod will be running and ready before it will be removed,derekwaynecarr,0 StatefulSet Basic StatefulSet functionality Scaling should happen in predictable order and halt if any pet is unhealthy,derekwaynecarr,0 StatefulSet Basic StatefulSet functionality should allow template updates,derekwaynecarr,0 -StatefulSet Basic StatefulSet functionality should handle healthy pet restarts during scale,girishkalele,1 +StatefulSet Basic StatefulSet functionality should handle healthy pet restarts during scale,kevin-wangzefeng,1 StatefulSet Basic StatefulSet functionality should provide basic identity,bprashanth,1 StatefulSet Deploy clustered applications should creating a working CockroachDB cluster,derekwaynecarr,0 StatefulSet Deploy clustered applications should creating a working mysql cluster,yujuhong,1 @@ -475,7 +476,7 @@ Sysctls should reject invalid sysctls,davidopp,1 Sysctls should support sysctls,Random-Liu,1 Sysctls should support unsafe sysctls which are actually whitelisted,deads2k,1 ThirdParty resources Simple Third Party creating/deleting thirdparty objects works,luxas,1 -Upgrade cluster upgrade should maintain a functioning cluster,girishkalele,1 +Upgrade cluster upgrade should maintain a functioning cluster,luxas,1 Upgrade cluster upgrade should maintain responsive services,mikedanese,1 Upgrade master upgrade should maintain responsive services,mikedanese,1 Upgrade node upgrade should maintain a functioning cluster,zmerlynn,1 @@ -506,8 +507,8 @@ k8s.io/kubernetes/cmd/kube-discovery/app,pmorie,1 k8s.io/kubernetes/cmd/kube-proxy/app,luxas,1 k8s.io/kubernetes/cmd/kubeadm/app/cmd,caesarxuchao,1 k8s.io/kubernetes/cmd/kubeadm/app/images,davidopp,1 -k8s.io/kubernetes/cmd/kubeadm/app/node,apprenda,0 k8s.io/kubernetes/cmd/kubeadm/app/master,apprenda,0 +k8s.io/kubernetes/cmd/kubeadm/app/node,apprenda,0 k8s.io/kubernetes/cmd/kubeadm/app/preflight,apprenda,0 k8s.io/kubernetes/cmd/kubeadm/app/util,krousey,1 k8s.io/kubernetes/cmd/kubeadm/test,pipejakob,0 @@ -550,8 +551,6 @@ k8s.io/kubernetes/pkg/api/meta,fabioy,1 k8s.io/kubernetes/pkg/api/resource,smarterclayton,1 k8s.io/kubernetes/pkg/api/service,spxtr,1 k8s.io/kubernetes/pkg/api/testapi,caesarxuchao,1 -k8s.io/kubernetes/pkg/api/unversioned,kevin-wangzefeng,1 -k8s.io/kubernetes/pkg/api/unversioned/validation,brendandburns,1 k8s.io/kubernetes/pkg/api/util,ghodss,1 k8s.io/kubernetes/pkg/api/v1,vulpecula,1 k8s.io/kubernetes/pkg/api/v1/endpoints,sttts,0 @@ -575,6 +574,7 @@ k8s.io/kubernetes/pkg/apis/extensions,bgrant0607,1 k8s.io/kubernetes/pkg/apis/extensions/v1beta1,madhusudancs,1 k8s.io/kubernetes/pkg/apis/extensions/validation,nikhiljindal,1 k8s.io/kubernetes/pkg/apis/meta/v1,sttts,0 +k8s.io/kubernetes/pkg/apis/meta/v1/validation,jszczepkowski,1 k8s.io/kubernetes/pkg/apis/policy/validation,deads2k,1 k8s.io/kubernetes/pkg/apis/rbac/validation,erictune,0 k8s.io/kubernetes/pkg/apis/storage/validation,caesarxuchao,1 @@ -610,7 +610,7 @@ k8s.io/kubernetes/pkg/cloudprovider/providers/cloudstack,roberthbailey,1 k8s.io/kubernetes/pkg/cloudprovider/providers/gce,yifan-gu,1 k8s.io/kubernetes/pkg/cloudprovider/providers/mesos,mml,1 k8s.io/kubernetes/pkg/cloudprovider/providers/openstack,Q-Lee,1 -k8s.io/kubernetes/pkg/cloudprovider/providers/ovirt,girishkalele,1 +k8s.io/kubernetes/pkg/cloudprovider/providers/ovirt,dchen1107,1 k8s.io/kubernetes/pkg/cloudprovider/providers/photon,luomiao,0 k8s.io/kubernetes/pkg/cloudprovider/providers/rackspace,caesarxuchao,1 k8s.io/kubernetes/pkg/cloudprovider/providers/vsphere,apelisse,1 @@ -734,7 +734,7 @@ k8s.io/kubernetes/pkg/registry/core/controller,freehan,1 k8s.io/kubernetes/pkg/registry/core/controller/etcd,fabioy,1 k8s.io/kubernetes/pkg/registry/core/endpoint,bprashanth,1 k8s.io/kubernetes/pkg/registry/core/endpoint/etcd,mikedanese,1 -k8s.io/kubernetes/pkg/registry/core/event,girishkalele,1 +k8s.io/kubernetes/pkg/registry/core/event,ixdy,1 k8s.io/kubernetes/pkg/registry/core/event/etcd,yujuhong,1 k8s.io/kubernetes/pkg/registry/core/limitrange,yifan-gu,1 k8s.io/kubernetes/pkg/registry/core/limitrange/etcd,mikedanese,1 @@ -821,7 +821,7 @@ k8s.io/kubernetes/pkg/util/bandwidth,thockin,1 k8s.io/kubernetes/pkg/util/cache,thockin,1 k8s.io/kubernetes/pkg/util/cert,karlkfi,1 k8s.io/kubernetes/pkg/util/clock,zmerlynn,1 -k8s.io/kubernetes/pkg/util/config,girishkalele,1 +k8s.io/kubernetes/pkg/util/config,jszczepkowski,1 k8s.io/kubernetes/pkg/util/configz,ixdy,1 k8s.io/kubernetes/pkg/util/dbus,roberthbailey,1 k8s.io/kubernetes/pkg/util/diff,piosz,1 @@ -872,7 +872,7 @@ k8s.io/kubernetes/pkg/util/yaml,rmmh,1 k8s.io/kubernetes/pkg/version,spxtr,1 k8s.io/kubernetes/pkg/volume,saad-ali,0 k8s.io/kubernetes/pkg/volume/aws_ebs,caesarxuchao,1 -k8s.io/kubernetes/pkg/volume/azure_dd,girishkalele,1 +k8s.io/kubernetes/pkg/volume/azure_dd,bgrant0607,1 k8s.io/kubernetes/pkg/volume/azure_file,maisem,1 k8s.io/kubernetes/pkg/volume/cephfs,eparis,1 k8s.io/kubernetes/pkg/volume/cinder,jsafrane,1