github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-07 19:23:40 +00:00
Code Issues Projects Releases Wiki Activity

kubectl/describe: use function calls to build field selector

Browse Source 
Instead of using string concatenation.

Signed-off-by: Jingyuan Liang <jingyuanliang@google.com>
This commit is contained in:
Jingyuan Liang 2024-08-08 00:53:04 +00:00
parent 60c4c2b252
commit a2dc34cb17
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
staging/src/k8s.io/kubectl/pkg/describe/describe.go
View File

@ -3631,10 +3631,11 @@ func (d *NodeDescriber) Describe(namespace, name string, describerSettings Descr
return "", err
}
fieldSelector, err := fields.ParseSelector("spec.nodeName=" + name + ",status.phase!=" + string(corev1.PodSucceeded) + ",status.phase!=" + string(corev1.PodFailed))
if err != nil {
return "", err
}
fieldSelector := fields.AndSelectors(
fields.OneTermEqualSelector("spec.nodeName", name),
fields.OneTermNotEqualSelector("status.phase", string(corev1.PodSucceeded)),
fields.OneTermNotEqualSelector("status.phase", string(corev1.PodFailed)),
)
// in a policy aware setting, users may have access to a node, but not all pods
// in that case, we note that the user does not have access to the pods
canViewPods := true