github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-10 12:32:03 +00:00
Code Issues Projects Releases Wiki Activity

test/integration/auth: fix data race

Browse Source 
"username" gets read by one goroutine and written by another. Therefore it must
be protected by a mutex to avoid triggering the race detector.
This commit is contained in:
Patrick Ohly 2023-04-04 12:17:26 +02:00
parent d89d5ab268
commit a2fb32870f
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
test/integration/auth/accessreview_test.go
View File

@ -21,6 +21,7 @@ import (
"errors" "errors"
"net/http" "net/http"
"strings" "strings"
"sync"
"testing" "testing"
authorizationapi "k8s.io/api/authorization/v1" authorizationapi "k8s.io/api/authorization/v1"
@ -148,8 +149,12 @@ func TestSubjectAccessReview(t *testing.T) {
} }
func TestSelfSubjectAccessReview(t *testing.T) { func TestSelfSubjectAccessReview(t *testing.T) {
var mutex sync.Mutex
username := "alice" username := "alice"
authenticatorFunc := func(req *http.Request) (*authenticator.Response, bool, error) { authenticatorFunc := func(req *http.Request) (*authenticator.Response, bool, error) {
mutex.Lock()
defer mutex.Unlock()
return &authenticator.Response{ return &authenticator.Response{
User: &user.DefaultInfo{ User: &user.DefaultInfo{
Name: username, Name: username,
@ -216,7 +221,9 @@ func TestSelfSubjectAccessReview(t *testing.T) {
} }
for _, test := range tests { for _, test := range tests {
mutex.Lock()
username = test.username username = test.username
mutex.Unlock()
response, err := clientset.AuthorizationV1().SelfSubjectAccessReviews().Create(context.TODO(), test.sar, metav1.CreateOptions{}) response, err := clientset.AuthorizationV1().SelfSubjectAccessReviews().Create(context.TODO(), test.sar, metav1.CreateOptions{})
switch { switch {