From a5f782face1172e8d7ec3a070e907b1257bab726 Mon Sep 17 00:00:00 2001 From: Ted Yu Date: Fri, 20 Dec 2019 19:43:36 -0800 Subject: [PATCH] Reuse converter in crdHandler#getOrCreateServingInfoFor --- .../pkg/apiserver/customresource_handler.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/customresource_handler.go b/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/customresource_handler.go index 0c58cf191b3..0d7617953f6 100644 --- a/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/customresource_handler.go +++ b/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/customresource_handler.go @@ -662,11 +662,11 @@ func (r *crdHandler) getOrCreateServingInfoFor(uid types.UID, name string) (*crd openAPIModels = nil } + safeConverter, unsafeConverter, err := r.converterFactory.NewConverter(crd) + if err != nil { + return nil, err + } for _, v := range crd.Spec.Versions { - safeConverter, unsafeConverter, err := r.converterFactory.NewConverter(crd) - if err != nil { - return nil, err - } // In addition to Unstructured objects (Custom Resources), we also may sometimes need to // decode unversioned Options objects, so we delegate to parameterScheme for such types. parameterScheme := runtime.NewScheme()