diff --git a/pkg/api/persistentvolume/util.go b/pkg/api/persistentvolume/util.go index 5f929297a27..28f1bfc0c54 100644 --- a/pkg/api/persistentvolume/util.go +++ b/pkg/api/persistentvolume/util.go @@ -31,9 +31,9 @@ const ( deprecatedStorageClassAnnotationsMsg = `deprecated since v1.8; use "storageClassName" attribute instead` ) -// DropDisabledFields removes disabled fields from the pv spec. +// DropDisabledSpecFields removes disabled fields from the pv spec. // This should be called from PrepareForCreate/PrepareForUpdate for all resources containing a pv spec. -func DropDisabledFields(pvSpec *api.PersistentVolumeSpec, oldPVSpec *api.PersistentVolumeSpec) { +func DropDisabledSpecFields(pvSpec *api.PersistentVolumeSpec, oldPVSpec *api.PersistentVolumeSpec) { if !utilfeature.DefaultFeatureGate.Enabled(features.CSINodeExpandSecret) && !hasNodeExpansionSecrets(oldPVSpec) { if pvSpec.CSI != nil { pvSpec.CSI.NodeExpandSecretRef = nil diff --git a/pkg/api/persistentvolume/util_test.go b/pkg/api/persistentvolume/util_test.go index 5000f3adf75..e3f450282da 100644 --- a/pkg/api/persistentvolume/util_test.go +++ b/pkg/api/persistentvolume/util_test.go @@ -91,7 +91,7 @@ func TestDropDisabledFields(t *testing.T) { t.Run(name, func(t *testing.T) { defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.CSINodeExpandSecret, tc.csiExpansionEnabled)() - DropDisabledFields(tc.newSpec, tc.oldSpec) + DropDisabledSpecFields(tc.newSpec, tc.oldSpec) if !reflect.DeepEqual(tc.newSpec, tc.expectNewSpec) { t.Error(cmp.Diff(tc.newSpec, tc.expectNewSpec)) } diff --git a/pkg/registry/core/persistentvolume/strategy.go b/pkg/registry/core/persistentvolume/strategy.go index e175a4097ad..16c1d9528df 100644 --- a/pkg/registry/core/persistentvolume/strategy.go +++ b/pkg/registry/core/persistentvolume/strategy.go @@ -66,7 +66,7 @@ func (persistentvolumeStrategy) PrepareForCreate(ctx context.Context, obj runtim pv := obj.(*api.PersistentVolume) pv.Status = api.PersistentVolumeStatus{} - pvutil.DropDisabledFields(&pv.Spec, nil) + pvutil.DropDisabledSpecFields(&pv.Spec, nil) } func (persistentvolumeStrategy) Validate(ctx context.Context, obj runtime.Object) field.ErrorList { @@ -95,7 +95,7 @@ func (persistentvolumeStrategy) PrepareForUpdate(ctx context.Context, obj, old r oldPv := old.(*api.PersistentVolume) newPv.Status = oldPv.Status - pvutil.DropDisabledFields(&newPv.Spec, &oldPv.Spec) + pvutil.DropDisabledSpecFields(&newPv.Spec, &oldPv.Spec) } func (persistentvolumeStrategy) ValidateUpdate(ctx context.Context, obj, old runtime.Object) field.ErrorList {