From a343a93b2d4fddabfde30d82f9dd2aaf6cc791a4 Mon Sep 17 00:00:00 2001 From: Brendan Burns Date: Tue, 9 Sep 2014 09:55:55 -0700 Subject: [PATCH] Fix a bug where we don't return an error. --- pkg/proxy/config/etcd.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pkg/proxy/config/etcd.go b/pkg/proxy/config/etcd.go index 1795b10e1e4..a3a9a6a5f4e 100644 --- a/pkg/proxy/config/etcd.go +++ b/pkg/proxy/config/etcd.go @@ -120,10 +120,12 @@ func (s ConfigSourceEtcd) Run() { func (s ConfigSourceEtcd) GetServices() ([]api.Service, []api.Endpoints, error) { response, err := s.client.Get(registryRoot+"/specs", true, false) if err != nil { - glog.V(1).Infof("Failed to get the key %s: %v", registryRoot, err) if tools.IsEtcdNotFound(err) { - return []api.Service{}, []api.Endpoints{}, err + glog.V(1).Infof("Failed to get the key %s: %v", registryRoot, err) + } else { + glog.Errorf("Failed to contact etcd for key %s: %v", registryRoot, err) } + return []api.Service{}, []api.Endpoints{}, err } if response.Node.Dir == true { retServices := make([]api.Service, len(response.Node.Nodes))