github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-28 14:07:14 +00:00
Code Issues Projects Releases Wiki Activity

conversion-gen: Report an error in conversion when names don't match

Browse Source
This commit is contained in:
Clayton Coleman 2018-07-03 15:25:48 -04:00
parent eb85c83e92
commit a36fd65c5a
No known key found for this signature in database
GPG Key ID: 3D16906B4F1C5CB3
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
staging/src/k8s.io/code-generator/cmd/conversion-gen/generators/conversion.go
View File

@ -179,6 +179,10 @@ func getManualConversionFunctions(context *generator.Context, pkg *types.Package
} }
manualMap[key] = f manualMap[key] = f
} else { } else {
// prevent user error when they don't get the correct conversion signature
if strings.HasPrefix(f.Name.Name, "Convert_") {
glog.Errorf("Rename function %s %s -> %s to match expected conversion signature", f.Name.Package, f.Name.Name, buffer.String())
}
glog.V(8).Infof("%s has wrong name", f.Name) glog.V(8).Infof("%s has wrong name", f.Name)
} }
buffer.Reset() buffer.Reset()