github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-05 10:19:50 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #95602 from chenyw1990/master

Browse Source 
write checkpoint only when allocated devices updated.
This commit is contained in:
Kubernetes Prow Robot 2020-10-22 20:35:36 -07:00 committed by GitHub
commit a4209939f8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/kubelet/cm/devicemanager/manager.go
View File

@ -833,6 +833,7 @@ func (m *ManagerImpl) allocateContainerResources(pod *v1.Pod, container *v1.Cont
podUID := string(pod.UID) podUID := string(pod.UID)
contName := container.Name contName := container.Name
allocatedDevicesUpdated := false allocatedDevicesUpdated := false
needsUpdateCheckpoint := false
// Extended resources are not allowed to be overcommitted. // Extended resources are not allowed to be overcommitted.
// Since device plugin advertises extended resources, // Since device plugin advertises extended resources,
// therefore Requests must be equal to Limits and iterating // therefore Requests must be equal to Limits and iterating
@ -858,6 +859,8 @@ func (m *ManagerImpl) allocateContainerResources(pod *v1.Pod, container *v1.Cont
continue continue
} }
needsUpdateCheckpoint = true
startRPCTime := time.Now() startRPCTime := time.Now()
// Manager.Allocate involves RPC calls to device plugin, which // Manager.Allocate involves RPC calls to device plugin, which
// could be heavy-weight. Therefore we want to perform this operation outside // could be heavy-weight. Therefore we want to perform this operation outside
@ -906,8 +909,11 @@ func (m *ManagerImpl) allocateContainerResources(pod *v1.Pod, container *v1.Cont
m.mutex.Unlock() m.mutex.Unlock()
} }
// Checkpoints device to container allocation information. if needsUpdateCheckpoint {
return m.writeCheckpoint() return m.writeCheckpoint()
}
return nil
} }
// GetDeviceRunContainerOptions checks whether we have cached containerDevices // GetDeviceRunContainerOptions checks whether we have cached containerDevices