github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-27 05:27:21 +00:00
Code Issues Projects Releases Wiki Activity

node-controller: deflake TestUpdateNodeWithMultiplePods

Browse Source 
Use absolute time and increase grace duration to 500ms for tests under load.
This commit is contained in:
Dr. Stefan Schimanski 2017-04-28 14:03:29 +02:00
parent 94567f64e1
commit a426adcb2f
1 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
pkg/controller/node/taint_controller_test.go
View File

@ -26,7 +26,6 @@ import (
"k8s.io/kubernetes/pkg/client/clientset_generated/clientset/fake" "k8s.io/kubernetes/pkg/client/clientset_generated/clientset/fake"
"k8s.io/kubernetes/pkg/controller/node/testutil" "k8s.io/kubernetes/pkg/controller/node/testutil"
"github.com/golang/glog"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
clienttesting "k8s.io/client-go/testing" clienttesting "k8s.io/client-go/testing"
) )
@ -481,6 +480,8 @@ func TestUpdateNodeWithMultiplePods(t *testing.T) {
} }
for _, item := range testCases { for _, item := range testCases {
t.Logf("Starting testcase %q", item.description)
stopCh := make(chan struct{}) stopCh := make(chan struct{})
fakeClientset := fake.NewSimpleClientset(&v1.PodList{Items: item.pods}) fakeClientset := fake.NewSimpleClientset(&v1.PodList{Items: item.pods})
sort.Sort(item.expectedDeleteTimes) sort.Sort(item.expectedDeleteTimes)
@ -489,19 +490,24 @@ func TestUpdateNodeWithMultiplePods(t *testing.T) {
go controller.Run(stopCh) go controller.Run(stopCh)
controller.NodeUpdated(item.oldNode, item.newNode) controller.NodeUpdated(item.oldNode, item.newNode)
sleptAlready := time.Duration(0) startedAt := time.Now()
for i := range item.expectedDeleteTimes { for i := range item.expectedDeleteTimes {
var increment time.Duration
if i == 0 || item.expectedDeleteTimes[i-1].timestamp != item.expectedDeleteTimes[i].timestamp { if i == 0 || item.expectedDeleteTimes[i-1].timestamp != item.expectedDeleteTimes[i].timestamp {
// compute a grace duration to give controller time to process updates. Choose big
// enough intervals in the test cases above to avoid flakes.
var increment time.Duration
if i == len(item.expectedDeleteTimes)-1 || item.expectedDeleteTimes[i+1].timestamp == item.expectedDeleteTimes[i].timestamp { if i == len(item.expectedDeleteTimes)-1 || item.expectedDeleteTimes[i+1].timestamp == item.expectedDeleteTimes[i].timestamp {
increment = 200 * time.Millisecond increment = 500 * time.Millisecond
} else { } else {
increment = ((item.expectedDeleteTimes[i+1].timestamp - item.expectedDeleteTimes[i].timestamp) / time.Duration(2)) increment = ((item.expectedDeleteTimes[i+1].timestamp - item.expectedDeleteTimes[i].timestamp) / time.Duration(2))
} }
sleepTime := item.expectedDeleteTimes[i].timestamp - sleptAlready + increment
glog.Infof("Sleeping for %v", sleepTime) sleepTime := item.expectedDeleteTimes[i].timestamp - time.Since(startedAt) + increment
if sleepTime < 0 {
sleepTime = 0
}
t.Logf("Sleeping for %v", sleepTime)
time.Sleep(sleepTime) time.Sleep(sleepTime)
sleptAlready = item.expectedDeleteTimes[i].timestamp + increment
} }
for delay, podName := range item.expectedDeleteTimes[i].names { for delay, podName := range item.expectedDeleteTimes[i].names {
@ -509,7 +515,7 @@ func TestUpdateNodeWithMultiplePods(t *testing.T) {
for _, action := range fakeClientset.Actions() { for _, action := range fakeClientset.Actions() {
deleteAction, ok := action.(clienttesting.DeleteActionImpl) deleteAction, ok := action.(clienttesting.DeleteActionImpl)
if !ok { if !ok {
glog.Infof("Found not-delete action with verb %v. Ignoring.", action.GetVerb()) t.Logf("Found not-delete action with verb %v. Ignoring.", action.GetVerb())
continue continue
} }
if deleteAction.GetResource().Resource != "pods" { if deleteAction.GetResource().Resource != "pods" {
@ -526,7 +532,7 @@ func TestUpdateNodeWithMultiplePods(t *testing.T) {
for _, action := range fakeClientset.Actions() { for _, action := range fakeClientset.Actions() {
deleteAction, ok := action.(clienttesting.DeleteActionImpl) deleteAction, ok := action.(clienttesting.DeleteActionImpl)
if !ok { if !ok {
glog.Infof("Found not-delete action with verb %v. Ignoring.", action.GetVerb()) t.Logf("Found not-delete action with verb %v. Ignoring.", action.GetVerb())
continue continue
} }
if deleteAction.GetResource().Resource != "pods" { if deleteAction.GetResource().Resource != "pods" {