From 23c21b055cb0cda8c4890a269af6dfcbe2c1c2e8 Mon Sep 17 00:00:00 2001 From: Michael Taufen Date: Tue, 24 Apr 2018 09:12:31 -0700 Subject: [PATCH] Fix qosReserved json tag (lowercase qos, instead of uppercase QOS) The API conventions specify that json keys should start with a lowercase character, and if the key starts with an initialism, all characters in the initialism should be lowercase. See `tlsCipherSuites` as an example. API Conventions: https://github.com/kubernetes/community/blob/master/contributors/devel/api-conventions.md >All letters in the acronym should have the same case, using the >appropriate case for the situation. For example, at the beginning >of a field name, the acronym should be all lowercase, such as "httpGet". --- pkg/kubelet/apis/kubeletconfig/v1beta1/types.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/kubelet/apis/kubeletconfig/v1beta1/types.go b/pkg/kubelet/apis/kubeletconfig/v1beta1/types.go index ffddb247627..60d314bace6 100644 --- a/pkg/kubelet/apis/kubeletconfig/v1beta1/types.go +++ b/pkg/kubelet/apis/kubeletconfig/v1beta1/types.go @@ -260,7 +260,7 @@ type KubeletConfiguration struct { // Requires the QOSReserved feature gate to be enabled. // Default: nil // +optional - QOSReserved map[string]string `json:"QOSReserved,omitempty"` + QOSReserved map[string]string `json:"qosReserved,omitempty"` // runtimeRequestTimeout is the timeout for all runtime requests except long running // requests - pull, logs, exec and attach. // Default: "2m"