github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-23 19:56:01 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #66322 from tanshanshan/fixunused

Browse Source 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

ignore unused variable

**What this PR does / why we need it**:
ignore unused variable 

unused err
162655f42f/pkg/cloudprovider/providers/openstack/openstack_routes_test.go (L89)

and
unused instanceId
162655f42f/pkg/cloudprovider/providers/photon/photon_test.go (L143)

found in #66303 
**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:


**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
This commit is contained in:
Kubernetes Submit Queue 2018-08-27 02:48:52 -07:00 committed by GitHub
commit a431feb24e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/cloudprovider/providers/openstack/openstack_routes_test.go
View File

@ -87,6 +87,9 @@ func TestRoutes(t *testing.T) {
func getServers(os *OpenStack) []servers.Server { func getServers(os *OpenStack) []servers.Server {
c, err := os.NewComputeV2() c, err := os.NewComputeV2()
if err != nil {
panic(err)
}
allPages, err := servers.List(c, servers.ListOpts{}).AllPages() allPages, err := servers.List(c, servers.ListOpts{}).AllPages()
if err != nil { if err != nil {
panic(err) panic(err)

2
pkg/cloudprovider/providers/photon/photon_test.go
View File

@ -140,7 +140,7 @@ func TestInstances(t *testing.T) {
} }
t.Logf("Found InstanceID(%s) = %s\n", testVM, instanceId) t.Logf("Found InstanceID(%s) = %s\n", testVM, instanceId)
instanceId, err = i.InstanceID(context.TODO(), nonExistingVM) _, err = i.InstanceID(context.TODO(), nonExistingVM)
if err == cloudprovider.InstanceNotFound { if err == cloudprovider.InstanceNotFound {
t.Logf("VM %s was not found as expected\n", nonExistingVM) t.Logf("VM %s was not found as expected\n", nonExistingVM)
} else if err == nil { } else if err == nil {