github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-22 11:21:47 +00:00
Code Issues Projects Releases Wiki Activity

optimize nil and empty also for slices

Browse Source 
brings to parity with maps
This commit is contained in:
Alexander Zielenski 2022-07-20 10:18:42 -07:00
parent 48786d90da
commit a4819996a8
No known key found for this signature in database
GPG Key ID: 754BC11B447F7843
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
staging/src/k8s.io/apimachinery/third_party/forked/golang/reflect/deep_equal.go vendored
View File

@ -169,6 +169,18 @@ func (e Equalities) deepValueEqual(v1, v2 reflect.Value, visited map[visit]bool,
if v1.IsNil() != v2.IsNil() { if v1.IsNil() != v2.IsNil() {
return false return false
} }
// Optimize nil and empty cases
// Two lists that are BOTH nil are equal
// No need to check v2 is nil since v1.IsNil == v2.IsNil from above
if v1.IsNil() {
return true
}
// Two lists that are both empty and both non nil are equal
if v1.Len() == 0 || v2.Len() == 0 {
return true
}
} }
if v1.Len() != v2.Len() { if v1.Len() != v2.Len() {
return false return false
@ -210,13 +222,13 @@ func (e Equalities) deepValueEqual(v1, v2 reflect.Value, visited map[visit]bool,
} }
// Optimize nil and empty cases // Optimize nil and empty cases
// Two lists that are BOTH nil are equal // Two maps that are BOTH nil are equal
// No need to check v2 is nil since v1.IsNil == v2.IsNil from above // No need to check v2 is nil since v1.IsNil == v2.IsNil from above
if v1.IsNil() { if v1.IsNil() {
return true return true
} }
// Two lists that are both empty and both non nil are equal // Two maps that are both empty and both non nil are equal
if v1.Len() == 0 || v2.Len() == 0 { if v1.Len() == 0 || v2.Len() == 0 {
return true return true
} }