github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-06 02:34:03 +00:00
Code Issues Projects Releases Wiki Activity

Cleanly delete service without endpoints key

Browse Source 
If a service is deleted before the etcd key corresponding to its
endpoints has been created, a 500 error is returned (etcd key
not found).  Instead, key not found should be ignored silently.

There is a potential race condition with the controller creating
endpoints after the service has been deleted which a cleanup task
should handle in the future.

Closes #684
This commit is contained in:
Clayton Coleman 2014-07-29 11:42:19 -04:00
parent f87bd6b8f9
commit a49b331794
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
pkg/registry/etcd_registry.go
View File

@ -274,6 +274,10 @@ func (registry *EtcdRegistry) GetService(name string) (*api.Service, error) {
return &svc, nil return &svc, nil
} }
func makeServiceEndpointsKey(name string) string {
return "/registry/services/endpoints/" + name
}
// DeleteService deletes a Service specified by its name. // DeleteService deletes a Service specified by its name.
func (registry *EtcdRegistry) DeleteService(name string) error { func (registry *EtcdRegistry) DeleteService(name string) error {
key := makeServiceKey(name) key := makeServiceKey(name)
@ -284,9 +288,12 @@ func (registry *EtcdRegistry) DeleteService(name string) error {
if err != nil { if err != nil {
return err return err
} }
key = "/registry/services/endpoints/" + name key = makeServiceEndpointsKey(name)
_, err = registry.etcdClient.Delete(key, true) _, err = registry.etcdClient.Delete(key, true)
return err if !tools.IsEtcdNotFound(err) {
return err
}
return nil
} }
// UpdateService replaces an existing Service. // UpdateService replaces an existing Service.