From a4e562932095d14fedd5cb247ced13ff87665c57 Mon Sep 17 00:00:00 2001 From: Gaurav Singh Date: Tue, 26 May 2020 09:29:06 -0400 Subject: [PATCH] scheduler_test: fix goroutine leak Signed-off-by: Gaurav Singh Re-use errchan from setupTestSchedulerWithOnePodOnNode Signed-off-by: Gaurav Singh --- pkg/scheduler/scheduler_test.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pkg/scheduler/scheduler_test.go b/pkg/scheduler/scheduler_test.go index 015e8152d7c..f5a41ad8df5 100644 --- a/pkg/scheduler/scheduler_test.go +++ b/pkg/scheduler/scheduler_test.go @@ -543,11 +543,10 @@ func TestSchedulerNoPhantomPodAfterExpire(t *testing.T) { st.RegisterBindPlugin(defaultbinder.Name, defaultbinder.New), st.RegisterPluginAsExtensions(nodeports.Name, nodeports.New, "Filter", "PreFilter"), } - scheduler, bindingChan, _ := setupTestSchedulerWithOnePodOnNode(t, queuedPodStore, scache, informerFactory, stop, pod, &node, fns...) + scheduler, bindingChan, errChan := setupTestSchedulerWithOnePodOnNode(t, queuedPodStore, scache, informerFactory, stop, pod, &node, fns...) waitPodExpireChan := make(chan struct{}) timeout := make(chan struct{}) - errChan := make(chan error) go func() { for { select {