From 06e1b38768ba243d29dcc6a3fe51381d2624a62f Mon Sep 17 00:00:00 2001 From: tariqibrahim Date: Mon, 12 Aug 2019 21:16:23 -0700 Subject: [PATCH 1/2] [k8s.io/client-go]fix typo in eventseries_test.go method --- .../src/k8s.io/client-go/tools/events/eventseries_test.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/staging/src/k8s.io/client-go/tools/events/eventseries_test.go b/staging/src/k8s.io/client-go/tools/events/eventseries_test.go index e9b4acf183b..98ca9b9c111 100644 --- a/staging/src/k8s.io/client-go/tools/events/eventseries_test.go +++ b/staging/src/k8s.io/client-go/tools/events/eventseries_test.go @@ -168,17 +168,17 @@ func TestEventSeriesf(t *testing.T) { if item.expectUpdate { actualEvent := <-patchEvent t.Logf("%v - validating event affected by patch request", index) - validateEventSerie(strconv.Itoa(index), true, actualEvent, item.expect, t) + validateEventSeries(strconv.Itoa(index), true, actualEvent, item.expect, t) } else { actualEvent := <-createEvent t.Logf("%v - validating event affected by a create request", index) - validateEventSerie(strconv.Itoa(index), false, actualEvent, item.expect, t) + validateEventSeries(strconv.Itoa(index), false, actualEvent, item.expect, t) } } close(stopCh) } -func validateEventSerie(messagePrefix string, expectedUpdate bool, actualEvent *v1beta1.Event, expectedEvent *v1beta1.Event, t *testing.T) { +func validateEventSeries(messagePrefix string, expectedUpdate bool, actualEvent *v1beta1.Event, expectedEvent *v1beta1.Event, t *testing.T) { recvEvent := *actualEvent // Just check that the timestamp was set. From 805640382339f646a175f04f9e4846d5bf2ef61f Mon Sep 17 00:00:00 2001 From: Tariq Ibrahim Date: Tue, 13 Aug 2019 09:07:39 -0700 Subject: [PATCH 2/2] Address review comments --- .../src/k8s.io/client-go/tools/events/eventseries_test.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/staging/src/k8s.io/client-go/tools/events/eventseries_test.go b/staging/src/k8s.io/client-go/tools/events/eventseries_test.go index 98ca9b9c111..c930c189fab 100644 --- a/staging/src/k8s.io/client-go/tools/events/eventseries_test.go +++ b/staging/src/k8s.io/client-go/tools/events/eventseries_test.go @@ -168,17 +168,17 @@ func TestEventSeriesf(t *testing.T) { if item.expectUpdate { actualEvent := <-patchEvent t.Logf("%v - validating event affected by patch request", index) - validateEventSeries(strconv.Itoa(index), true, actualEvent, item.expect, t) + validateEvent(strconv.Itoa(index), true, actualEvent, item.expect, t) } else { actualEvent := <-createEvent t.Logf("%v - validating event affected by a create request", index) - validateEventSeries(strconv.Itoa(index), false, actualEvent, item.expect, t) + validateEvent(strconv.Itoa(index), false, actualEvent, item.expect, t) } } close(stopCh) } -func validateEventSeries(messagePrefix string, expectedUpdate bool, actualEvent *v1beta1.Event, expectedEvent *v1beta1.Event, t *testing.T) { +func validateEvent(messagePrefix string, expectedUpdate bool, actualEvent *v1beta1.Event, expectedEvent *v1beta1.Event, t *testing.T) { recvEvent := *actualEvent // Just check that the timestamp was set.