From 848293ba29189dc43a437f26423ae5f09e78a667 Mon Sep 17 00:00:00 2001 From: Yuqi Wang Date: Thu, 4 Jul 2019 23:02:18 +0800 Subject: [PATCH] Extender bind should respect IsInterested --- pkg/scheduler/factory/factory.go | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/pkg/scheduler/factory/factory.go b/pkg/scheduler/factory/factory.go index 3a2e5a0fc9d..0de1a92f1e1 100644 --- a/pkg/scheduler/factory/factory.go +++ b/pkg/scheduler/factory/factory.go @@ -508,17 +508,12 @@ func (c *configFactory) CreateFromKeys(predicateKeys, priorityKeys sets.String, // getBinderFunc returns a func which returns an extender that supports bind or a default binder based on the given pod. func getBinderFunc(client clientset.Interface, extenders []algorithm.SchedulerExtender) func(pod *v1.Pod) Binder { - var extenderBinder algorithm.SchedulerExtender - for i := range extenders { - if extenders[i].IsBinder() { - extenderBinder = extenders[i] - break - } - } defaultBinder := &binder{client} return func(pod *v1.Pod) Binder { - if extenderBinder != nil && extenderBinder.IsInterested(pod) { - return extenderBinder + for _, extender := range extenders { + if extender.IsBinder() && extender.IsInterested(pod) { + return extender + } } return defaultBinder }