github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-11 04:52:08 +00:00
Code Issues Projects Releases Wiki Activity

Fix unit test for kubectl create role

Browse Source
This commit is contained in:
Cao Shufeng 2017-05-31 18:45:55 +08:00
parent 928dd707ba
commit a5865cfa1d
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
pkg/kubectl/cmd/create_role_test.go
View File

@ -344,8 +344,8 @@ func TestValidate(t *testing.T) {
for name, test := range tests { for name, test := range tests {
test.roleOptions.Mapper, _ = f.Object() test.roleOptions.Mapper, _ = f.Object()
err := test.roleOptions.Validate() err := test.roleOptions.Validate()
if test.expectErr && err != nil { if test.expectErr && err == nil {
continue t.Errorf("%s: expect error happens but validate passes.", name)
} }
if !test.expectErr && err != nil { if !test.expectErr && err != nil {
t.Errorf("%s: unexpected error: %v", name, err) t.Errorf("%s: unexpected error: %v", name, err)
@ -492,8 +492,13 @@ func TestComplete(t *testing.T) {
if !test.expectErr && err != nil { if !test.expectErr && err != nil {
t.Errorf("%s: unexpected error: %v", name, err) t.Errorf("%s: unexpected error: %v", name, err)
} }
if test.expectErr && err != nil {
continue if test.expectErr {
if err != nil {
continue
} else {
t.Errorf("%s: expect error happens but test passes.", name)
}
} }
if test.roleOptions.Name != test.expected.Name { if test.roleOptions.Name != test.expected.Name {