mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-22 03:11:40 +00:00
Merge pull request #83543 from yutedz/attach-resync-comment
Remove stale comment about resyncPeriod
This commit is contained in:
commit
a5dc1fffb0
@ -112,20 +112,6 @@ func NewAttachDetachController(
|
||||
disableReconciliationSync bool,
|
||||
reconcilerSyncDuration time.Duration,
|
||||
timerConfig TimerConfig) (AttachDetachController, error) {
|
||||
// TODO: The default resyncPeriod for shared informers is 12 hours, this is
|
||||
// unacceptable for the attach/detach controller. For example, if a pod is
|
||||
// skipped because the node it is scheduled to didn't set its annotation in
|
||||
// time, we don't want to have to wait 12hrs before processing the pod
|
||||
// again.
|
||||
// Luckily https://github.com/kubernetes/kubernetes/issues/23394 is being
|
||||
// worked on and will split resync in to resync and relist. Once that
|
||||
// happens the resync period can be set to something much faster (30
|
||||
// seconds).
|
||||
// If that issue is not resolved in time, then this controller will have to
|
||||
// consider some unappealing alternate options: use a non-shared informer
|
||||
// and set a faster resync period even if it causes relist, or requeue
|
||||
// dropped pods so they are continuously processed until it is accepted or
|
||||
// deleted (probably can't do this with sharedInformer), etc.
|
||||
adc := &attachDetachController{
|
||||
kubeClient: kubeClient,
|
||||
pvcLister: pvcInformer.Lister(),
|
||||
|
Loading…
Reference in New Issue
Block a user