From a5f3e24ab79ae57958da96d3f6dbaaf5e2672dfb Mon Sep 17 00:00:00 2001 From: globervinodhn Date: Thu, 28 Feb 2019 12:00:45 +0530 Subject: [PATCH] promote empty secret key test to conformance: Version updated to v1.15 --- test/conformance/testdata/conformance.txt | 1 + test/e2e/common/secrets.go | 7 ++++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/test/conformance/testdata/conformance.txt b/test/conformance/testdata/conformance.txt index 1881ea19a31..bf807d9fd90 100755 --- a/test/conformance/testdata/conformance.txt +++ b/test/conformance/testdata/conformance.txt @@ -148,6 +148,7 @@ test/e2e/common/projected_secret.go: "optional updates should be reflected in vo test/e2e/common/runtime.go: "should run with the expected status" test/e2e/common/secrets.go: "should be consumable from pods in env vars" test/e2e/common/secrets.go: "should be consumable via the environment" +test/e2e/common/secrets.go: "should fail to create secret due to empty secret key" test/e2e/common/secrets_volume.go: "should be consumable from pods in volume" test/e2e/common/secrets_volume.go: "should be consumable from pods in volume with defaultMode set" test/e2e/common/secrets_volume.go: "should be consumable from pods in volume as non-root with defaultMode and fsGroup set" diff --git a/test/e2e/common/secrets.go b/test/e2e/common/secrets.go index ce771c22ebd..8cb1d0e667a 100644 --- a/test/e2e/common/secrets.go +++ b/test/e2e/common/secrets.go @@ -126,7 +126,12 @@ var _ = Describe("[sig-api-machinery] Secrets", func() { }) }) - It("should fail to create secret in volume due to empty secret key", func() { + /* + Release : v1.15 + Testname: Secrets, with empty-key + Description: Attempt to create a Secret with an empty key. The creation MUST fail. + */ + framework.ConformanceIt("should fail to create secret due to empty secret key", func() { secret, err := createEmptyKeySecretForTest(f) Expect(err).To(HaveOccurred(), "created secret %q with empty key in namespace %q", secret.Name, f.Namespace.Name) })