github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-14 06:15:45 +00:00
Code Issues Projects Releases Wiki Activity

default enabled pod index for test cases, add test case disabling it

Browse Source
This commit is contained in:
Daniel Vega-Myhre 2023-07-05 18:47:45 +00:00
parent e0af0a5a45
commit a647f9febb
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/controller/job/job_controller_test.go
View File

@ -275,7 +275,7 @@ func TestControllerSyncJob(t *testing.T) {
// features // features
jobReadyPodsEnabled bool jobReadyPodsEnabled bool
podIndexLabelEnabled bool podIndexLabelDisabled bool
}{ }{
"job start": { "job start": {
parallelism: 2, parallelism: 2,
@ -782,7 +782,7 @@ func TestControllerSyncJob(t *testing.T) {
expectedActive: 2, expectedActive: 2,
expectedPodPatches: 2, expectedPodPatches: 2,
}, },
"indexed job with podIndexLabel feature enabled": { "indexed job with podIndexLabel feature disabled": {
parallelism: 2, parallelism: 2,
completions: 5, completions: 5,
backoffLimit: 6, backoffLimit: 6,
@ -790,14 +790,14 @@ func TestControllerSyncJob(t *testing.T) {
expectedCreations: 2, expectedCreations: 2,
expectedActive: 2, expectedActive: 2,
expectedCreatedIndexes: sets.New(0, 1), expectedCreatedIndexes: sets.New(0, 1),
podIndexLabelEnabled: true, podIndexLabelDisabled: true,
}, },
} }
for name, tc := range testCases { for name, tc := range testCases {
t.Run(name, func(t *testing.T) { t.Run(name, func(t *testing.T) {
defer featuregatetesting.SetFeatureGateDuringTest(t, feature.DefaultFeatureGate, features.JobReadyPods, tc.jobReadyPodsEnabled)() defer featuregatetesting.SetFeatureGateDuringTest(t, feature.DefaultFeatureGate, features.JobReadyPods, tc.jobReadyPodsEnabled)()
defer featuregatetesting.SetFeatureGateDuringTest(t, feature.DefaultFeatureGate, features.PodIndexLabel, tc.podIndexLabelEnabled)() defer featuregatetesting.SetFeatureGateDuringTest(t, feature.DefaultFeatureGate, features.PodIndexLabel, !tc.podIndexLabelDisabled)()
// job manager setup // job manager setup
clientSet := clientset.NewForConfigOrDie(&restclient.Config{Host: "", ContentConfig: restclient.ContentConfig{GroupVersion: &schema.GroupVersion{Group: "", Version: "v1"}}}) clientSet := clientset.NewForConfigOrDie(&restclient.Config{Host: "", ContentConfig: restclient.ContentConfig{GroupVersion: &schema.GroupVersion{Group: "", Version: "v1"}}})