diff --git a/hack/lib/test.sh b/hack/lib/test.sh index 575664a4dc0..7b9ee2b5f97 100644 --- a/hack/lib/test.sh +++ b/hack/lib/test.sh @@ -315,7 +315,7 @@ kube::test::version::object_to_file() { kube::test::version::json_object_to_file() { flags=$1 file=$2 - kubectl version $flags --output json | sed -e s/'\"'/''/g -e s/'}'/''/g -e s/'{'/''/g -e s/'clientVersion:'/'clientVersion:,'/ -e s/'serverVersion:'/'serverVersion:,'/ | tr , '\n' > "${file}" + kubectl version $flags --output json | sed -e s/' '/''/g -e s/'\"'/''/g -e s/'}'/''/g -e s/'{'/''/g -e s/'clientVersion:'/'clientVersion:,'/ -e s/'serverVersion:'/'serverVersion:,'/ | tr , '\n' > "${file}" } kube::test::version::json_client_server_object_to_file() { diff --git a/pkg/kubectl/cmd/version.go b/pkg/kubectl/cmd/version.go index 799db251e97..e9f3bac0dce 100644 --- a/pkg/kubectl/cmd/version.go +++ b/pkg/kubectl/cmd/version.go @@ -66,7 +66,7 @@ func NewCmdVersion(f cmdutil.Factory, out io.Writer) *cobra.Command { } cmd.Flags().BoolP("client", "c", false, "Client version only (no server required).") cmd.Flags().BoolP("short", "", false, "Print just the version number.") - cmd.Flags().String("output", "", "one of 'yaml' or 'json'") + cmd.Flags().StringP("output", "o", "", "One of 'yaml' or 'json'.") cmd.Flags().MarkShorthandDeprecated("client", "please use --client instead.") return cmd } @@ -117,7 +117,7 @@ func (o *VersionOptions) Run(f cmdutil.Factory, out io.Writer) error { } fmt.Fprintln(out, string(marshalled)) case "json": - marshalled, err := json.Marshal(&versionInfo) + marshalled, err := json.MarshalIndent(&versionInfo, "", " ") if err != nil { return err }