github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-23 19:56:01 +00:00
Code Issues Projects Releases Wiki Activity

Close the file after reading in verifydependencies#main

Browse Source
This commit is contained in:
Ted Yu 2019-10-19 10:46:50 -07:00
parent 0c91af21b4
commit a7231fc93a
1 changed files with 19 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cmd/verifydependencies/verifydependencies.go
View File

@ -72,10 +72,12 @@ func main() {
for _, dep := range externalDeps.Dependencies { for _, dep := range externalDeps.Dependencies {
for _, refPath := range dep.RefPaths { for _, refPath := range dep.RefPaths {
func() {
file, err := os.Open(refPath.Path) file, err := os.Open(refPath.Path)
if err != nil { if err != nil {
log.Fatalf("error opening file %v : %v", refPath.Path, err) log.Fatalf("error opening file %v : %v", refPath.Path, err)
} }
defer file.Close()
matcher := regexp.MustCompile(refPath.Match) matcher := regexp.MustCompile(refPath.Match)
depFileScanner := bufio.NewScanner(file) depFileScanner := bufio.NewScanner(file)
var found bool var found bool
@ -89,6 +91,7 @@ func main() {
if !found { if !found {
pathsToUpdate = append(pathsToUpdate, refPath.Path) pathsToUpdate = append(pathsToUpdate, refPath.Path)
} }
}()
} }
if len(pathsToUpdate) > 0 { if len(pathsToUpdate) > 0 {
log.Fatalf(mismatchErrorMessage, externalDepsFilePath, dep.Name, dep.Version, strings.Join(pathsToUpdate, "\n"), dep.Name, externalDepsFilePath) log.Fatalf(mismatchErrorMessage, externalDepsFilePath, dep.Name, dep.Version, strings.Join(pathsToUpdate, "\n"), dep.Name, externalDepsFilePath)