github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-05 02:09:56 +00:00
Code Issues Projects Releases Wiki Activity

Add authentication metrics: overall failure and error count

Browse Source
This commit is contained in:
RainbowMango 2019-08-16 19:30:43 +08:00
parent d7ecc85239
commit a7ac3b9bbe
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
staging/src/k8s.io/apiserver/pkg/endpoints/filters/authentication.go
View File

@ -40,6 +40,12 @@ import (
* involves explicitly acknowledging support for the metric across multiple releases, in accordance with * involves explicitly acknowledging support for the metric across multiple releases, in accordance with
* the metric stability policy. * the metric stability policy.
*/ */
const (
successLabel = "success"
failureLabel = "failure"
errorLabel = "error"
)
var ( var (
authenticatedUserCounter = metrics.NewCounterVec( authenticatedUserCounter = metrics.NewCounterVec(
&metrics.CounterOpts{ &metrics.CounterOpts{
@ -49,10 +55,19 @@ var (
}, },
[]string{"username"}, []string{"username"},
) )
authenticatedAttemptsCounter = metrics.NewCounterVec(
&metrics.CounterOpts{
Name: "authentication_attempts",
Help: "Counter of authenticated attempts.",
},
[]string{"result"},
)
) )
func init() { func init() {
legacyregistry.MustRegister(authenticatedUserCounter) legacyregistry.MustRegister(authenticatedUserCounter)
legacyregistry.MustRegister(authenticatedAttemptsCounter)
} }
// WithAuthentication creates an http handler that tries to authenticate the given request as a user, and then // WithAuthentication creates an http handler that tries to authenticate the given request as a user, and then
@ -72,7 +87,11 @@ func WithAuthentication(handler http.Handler, auth authenticator.Request, failed
if err != nil || !ok { if err != nil || !ok {
if err != nil { if err != nil {
klog.Errorf("Unable to authenticate the request due to an error: %v", err) klog.Errorf("Unable to authenticate the request due to an error: %v", err)
authenticatedAttemptsCounter.WithLabelValues(errorLabel).Inc()
} else if !ok {
authenticatedAttemptsCounter.WithLabelValues(failureLabel).Inc()
} }
failed.ServeHTTP(w, req) failed.ServeHTTP(w, req)
return return
} }
@ -86,6 +105,7 @@ func WithAuthentication(handler http.Handler, auth authenticator.Request, failed
req = req.WithContext(genericapirequest.WithUser(req.Context(), resp.User)) req = req.WithContext(genericapirequest.WithUser(req.Context(), resp.User))
authenticatedUserCounter.WithLabelValues(compressUsername(resp.User.GetName())).Inc() authenticatedUserCounter.WithLabelValues(compressUsername(resp.User.GetName())).Inc()
authenticatedAttemptsCounter.WithLabelValues(successLabel).Inc()
handler.ServeHTTP(w, req) handler.ServeHTTP(w, req)
}) })