From a7be958884ddc81df5e4c4398be849fd6dbac49e Mon Sep 17 00:00:00 2001 From: carlory Date: Tue, 7 Jan 2025 11:13:13 +0800 Subject: [PATCH] Remove general available feature-gate JobPodFailurePolicy --- pkg/features/kube_features.go | 7 ------- pkg/features/versioned_kube_features.go | 6 ------ .../test_data/versioned_feature_list.yaml | 14 -------------- 3 files changed, 27 deletions(-) diff --git a/pkg/features/kube_features.go b/pkg/features/kube_features.go index f9838d90796..bc08350a910 100644 --- a/pkg/features/kube_features.go +++ b/pkg/features/kube_features.go @@ -315,13 +315,6 @@ const ( // Allows to delegate reconciliation of a Job object to an external controller. JobManagedBy featuregate.Feature = "JobManagedBy" - // owner: @mimowo - // kep: https://kep.k8s.io/3329 - // - // Allow users to specify handling of pod failures based on container exit codes - // and pod conditions. - JobPodFailurePolicy featuregate.Feature = "JobPodFailurePolicy" - // owner: @kannon92 // kep : https://kep.k8s.io/3939 // diff --git a/pkg/features/versioned_kube_features.go b/pkg/features/versioned_kube_features.go index b3a0b54d60d..86825116377 100644 --- a/pkg/features/versioned_kube_features.go +++ b/pkg/features/versioned_kube_features.go @@ -441,12 +441,6 @@ var defaultVersionedKubernetesFeatureGates = map[featuregate.Feature]featuregate {Version: version.MustParse("1.32"), Default: true, PreRelease: featuregate.Beta}, }, - JobPodFailurePolicy: { - {Version: version.MustParse("1.25"), Default: false, PreRelease: featuregate.Alpha}, - {Version: version.MustParse("1.26"), Default: true, PreRelease: featuregate.Beta}, - {Version: version.MustParse("1.31"), Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.33 - }, - JobPodReplacementPolicy: { {Version: version.MustParse("1.28"), Default: false, PreRelease: featuregate.Alpha}, {Version: version.MustParse("1.29"), Default: true, PreRelease: featuregate.Beta}, diff --git a/test/featuregates_linter/test_data/versioned_feature_list.yaml b/test/featuregates_linter/test_data/versioned_feature_list.yaml index f77b99b1b24..9205bced0ff 100644 --- a/test/featuregates_linter/test_data/versioned_feature_list.yaml +++ b/test/featuregates_linter/test_data/versioned_feature_list.yaml @@ -600,20 +600,6 @@ lockToDefault: false preRelease: Beta version: "1.32" -- name: JobPodFailurePolicy - versionedSpecs: - - default: false - lockToDefault: false - preRelease: Alpha - version: "1.25" - - default: true - lockToDefault: false - preRelease: Beta - version: "1.26" - - default: true - lockToDefault: true - preRelease: GA - version: "1.31" - name: JobPodReplacementPolicy versionedSpecs: - default: false