github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-31 15:25:57 +00:00
Code Issues Projects Releases Wiki Activity

flocker unit test should clean up after itself

Browse Source
This commit is contained in:
James DeFelice 2015-10-06 14:06:10 +00:00
parent 0c089dcf11
commit a7c06e57ac
1 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
pkg/volume/flocker/plugin_test.go
View File

@ -17,6 +17,8 @@ limitations under the License.
package flocker package flocker
import ( import (
"io/ioutil"
"os"
"testing" "testing"
flockerClient "github.com/ClusterHQ/flocker-go" flockerClient "github.com/ClusterHQ/flocker-go"
@ -28,15 +30,17 @@ import (
const pluginName = "kubernetes.io/flocker" const pluginName = "kubernetes.io/flocker"
func newInitializedVolumePlugMgr() volume.VolumePluginMgr { func newInitializedVolumePlugMgr(t *testing.T) (volume.VolumePluginMgr, string) {
plugMgr := volume.VolumePluginMgr{} plugMgr := volume.VolumePluginMgr{}
plugMgr.InitPlugins(ProbeVolumePlugins(), volume.NewFakeVolumeHost("/foo/bar", nil, nil)) dir, err := ioutil.TempDir("", "flocker")
return plugMgr assert.NoError(t, err)
plugMgr.InitPlugins(ProbeVolumePlugins(), volume.NewFakeVolumeHost(dir, nil, nil))
return plugMgr, dir
} }
func TestGetByName(t *testing.T) { func TestGetByName(t *testing.T) {
assert := assert.New(t) assert := assert.New(t)
plugMgr := newInitializedVolumePlugMgr() plugMgr, _ := newInitializedVolumePlugMgr(t)
plug, err := plugMgr.FindPluginByName(pluginName) plug, err := plugMgr.FindPluginByName(pluginName)
assert.NotNil(plug, "Can't find the plugin by name") assert.NotNil(plug, "Can't find the plugin by name")
@ -45,7 +49,7 @@ func TestGetByName(t *testing.T) {
func TestCanSupport(t *testing.T) { func TestCanSupport(t *testing.T) {
assert := assert.New(t) assert := assert.New(t)
plugMgr := newInitializedVolumePlugMgr() plugMgr, _ := newInitializedVolumePlugMgr(t)
plug, err := plugMgr.FindPluginByName(pluginName) plug, err := plugMgr.FindPluginByName(pluginName)
assert.NoError(err) assert.NoError(err)
@ -113,7 +117,7 @@ func TestGetFlockerVolumeSource(t *testing.T) {
func TestNewBuilder(t *testing.T) { func TestNewBuilder(t *testing.T) {
assert := assert.New(t) assert := assert.New(t)
plugMgr := newInitializedVolumePlugMgr() plugMgr, _ := newInitializedVolumePlugMgr(t)
plug, err := plugMgr.FindPluginByName(pluginName) plug, err := plugMgr.FindPluginByName(pluginName)
assert.NoError(err) assert.NoError(err)
@ -196,7 +200,10 @@ func TestSetUpAtInternal(t *testing.T) {
assert := assert.New(t) assert := assert.New(t)
plugMgr := newInitializedVolumePlugMgr() plugMgr, rootDir := newInitializedVolumePlugMgr(t)
if rootDir != "" {
defer os.RemoveAll(rootDir)
}
plug, err := plugMgr.FindPluginByName(flockerPluginName) plug, err := plugMgr.FindPluginByName(flockerPluginName)
assert.NoError(err) assert.NoError(err)