From 0817af735c8e3c1deb6c3261ae46d083704a489e Mon Sep 17 00:00:00 2001 From: Mateusz Matejczyk Date: Tue, 24 Mar 2020 12:50:57 +0100 Subject: [PATCH] Remove the 'DisabledForLargeClusters' tags from ELB network tests. We did some internal testing at Google and, with the recent improvements, we believe that it's safe to re-enable these LB tests for large clusters. Ref. https://github.com/kubernetes/kubernetes/issues/56138 --- test/e2e/network/service.go | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/test/e2e/network/service.go b/test/e2e/network/service.go index 98e90852734..4cab4108c18 100644 --- a/test/e2e/network/service.go +++ b/test/e2e/network/service.go @@ -1151,8 +1151,7 @@ var _ = SIGDescribe("Services", func() { framework.ExpectNoError(err) }) - // TODO: Get rid of [DisabledForLargeClusters] tag when issue #56138 is fixed. - ginkgo.It("should be able to change the type and ports of a service [Slow] [DisabledForLargeClusters]", func() { + ginkgo.It("should be able to change the type and ports of a service [Slow]", func() { // requires cloud load-balancer support e2eskipper.SkipUnlessProviderIs("gce", "gke", "aws") @@ -2398,9 +2397,8 @@ var _ = SIGDescribe("Services", func() { execAffinityTestForNonLBServiceWithTransition(f, cs, svc) }) - // TODO: Get rid of [DisabledForLargeClusters] tag when issue #56138 is fixed. // [LinuxOnly]: Windows does not support session affinity. - ginkgo.It("should have session affinity work for LoadBalancer service with ESIPP on [Slow] [DisabledForLargeClusters] [LinuxOnly]", func() { + ginkgo.It("should have session affinity work for LoadBalancer service with ESIPP on [Slow] [LinuxOnly]", func() { // L4 load balancer affinity `ClientIP` is not supported on AWS ELB. e2eskipper.SkipIfProviderIs("aws") @@ -2410,9 +2408,8 @@ var _ = SIGDescribe("Services", func() { execAffinityTestForLBService(f, cs, svc) }) - // TODO: Get rid of [DisabledForLargeClusters] tag when issue #56138 is fixed. // [LinuxOnly]: Windows does not support session affinity. - ginkgo.It("should be able to switch session affinity for LoadBalancer service with ESIPP on [Slow] [DisabledForLargeClusters] [LinuxOnly]", func() { + ginkgo.It("should be able to switch session affinity for LoadBalancer service with ESIPP on [Slow] [LinuxOnly]", func() { // L4 load balancer affinity `ClientIP` is not supported on AWS ELB. e2eskipper.SkipIfProviderIs("aws") @@ -2422,9 +2419,8 @@ var _ = SIGDescribe("Services", func() { execAffinityTestForLBServiceWithTransition(f, cs, svc) }) - // TODO: Get rid of [DisabledForLargeClusters] tag when issue #56138 is fixed. // [LinuxOnly]: Windows does not support session affinity. - ginkgo.It("should have session affinity work for LoadBalancer service with ESIPP off [Slow] [DisabledForLargeClusters] [LinuxOnly]", func() { + ginkgo.It("should have session affinity work for LoadBalancer service with ESIPP off [Slow] [LinuxOnly]", func() { // L4 load balancer affinity `ClientIP` is not supported on AWS ELB. e2eskipper.SkipIfProviderIs("aws") @@ -2434,9 +2430,8 @@ var _ = SIGDescribe("Services", func() { execAffinityTestForLBService(f, cs, svc) }) - // TODO: Get rid of [DisabledForLargeClusters] tag when issue #56138 is fixed. // [LinuxOnly]: Windows does not support session affinity. - ginkgo.It("should be able to switch session affinity for LoadBalancer service with ESIPP off [Slow] [DisabledForLargeClusters] [LinuxOnly]", func() { + ginkgo.It("should be able to switch session affinity for LoadBalancer service with ESIPP off [Slow] [LinuxOnly]", func() { // L4 load balancer affinity `ClientIP` is not supported on AWS ELB. e2eskipper.SkipIfProviderIs("aws") @@ -2788,8 +2783,7 @@ var _ = SIGDescribe("Services", func() { }) }) -// TODO: Get rid of [DisabledForLargeClusters] tag when issue #56138 is fixed. -var _ = SIGDescribe("ESIPP [Slow] [DisabledForLargeClusters]", func() { +var _ = SIGDescribe("ESIPP [Slow]", func() { f := framework.NewDefaultFramework("esipp") var loadBalancerCreateTimeout time.Duration