github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-03 09:22:44 +00:00
Code Issues Projects Releases Wiki Activity

Addressed review comments.

Browse Source
This commit is contained in:
Madhusudan.C.S 2016-06-23 12:33:41 -07:00
parent 6894e74027
commit a827ef0713
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/dns/dns.go
View File

@ -649,7 +649,8 @@ func (kd *KubeDNS) getClusterZoneAndRegion() (string, string, error) {
return "", "", fmt.Errorf("failed to retrieve the cluster nodes: %v", err) return "", "", fmt.Errorf("failed to retrieve the cluster nodes: %v", err)
} }
// Select a node (arbitrarily the first node) that has `LabelZoneFailureDomain` set. // Select a node (arbitrarily the first node) that has
// `LabelZoneFailureDomain` and `LabelZoneRegion` set.
for _, nodeItem := range nodeList.Items { for _, nodeItem := range nodeList.Items {
_, zfound := nodeItem.Labels[unversioned.LabelZoneFailureDomain] _, zfound := nodeItem.Labels[unversioned.LabelZoneFailureDomain]
_, rfound := nodeItem.Labels[unversioned.LabelZoneRegion] _, rfound := nodeItem.Labels[unversioned.LabelZoneRegion]
@ -661,6 +662,8 @@ func (kd *KubeDNS) getClusterZoneAndRegion() (string, string, error) {
if err := kd.nodesStore.Add(node); err != nil { if err := kd.nodesStore.Add(node); err != nil {
return "", "", fmt.Errorf("couldn't add the retrieved node to the cache: %v", err) return "", "", fmt.Errorf("couldn't add the retrieved node to the cache: %v", err)
} }
// Node is found, break out of the loop.
break
} }
} }