From a8506146138e659d46aa48efb21a6fef8d9a4c44 Mon Sep 17 00:00:00 2001 From: Yu-Ju Hong Date: Thu, 7 Sep 2017 16:05:02 -0700 Subject: [PATCH] dockershim: check if f.Sync() returns an error and surface it --- pkg/kubelet/dockershim/checkpoint_store.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/kubelet/dockershim/checkpoint_store.go b/pkg/kubelet/dockershim/checkpoint_store.go index be9994fb939..b8160bbd9bd 100644 --- a/pkg/kubelet/dockershim/checkpoint_store.go +++ b/pkg/kubelet/dockershim/checkpoint_store.go @@ -76,7 +76,10 @@ func writeFileAndSync(filename string, data []byte, perm os.FileMode) error { if err == nil && n < len(data) { err = io.ErrShortWrite } - f.Sync() + if err == nil { + // Only sync if the Write completed successfully. + err = f.Sync() + } if err1 := f.Close(); err == nil { err = err1 }