From a862a269b0416045382092ca6d48559ff45f7809 Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Wed, 21 Dec 2022 14:05:14 +0100 Subject: [PATCH] test/integration/logs: remove useless stats case The same effect can be achieved with `-bench=BenchmarkEncoding/none`. --- test/integration/logs/benchmark/README.md | 4 ++-- test/integration/logs/benchmark/benchmark_test.go | 5 ----- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/test/integration/logs/benchmark/README.md b/test/integration/logs/benchmark/README.md index faa63d054e8..44fd0bb53f9 100644 --- a/test/integration/logs/benchmark/README.md +++ b/test/integration/logs/benchmark/README.md @@ -6,7 +6,7 @@ must be benchmarked before and after the change. ## Running the benchmark ``` -$ go test -bench=. -test.benchmem -benchmem . +go test -v -bench=. -benchmem -benchtime=10s . ``` ## Real log data @@ -59,5 +59,5 @@ While loading a file, some statistics about it are collected. Those are shown when running with: ``` -$ go test -v -bench=. -test.benchmem -benchmem . +go test -v -bench=BenchmarkEncoding/none -run=none . ``` diff --git a/test/integration/logs/benchmark/benchmark_test.go b/test/integration/logs/benchmark/benchmark_test.go index e45eed423f8..ba40436eea8 100644 --- a/test/integration/logs/benchmark/benchmark_test.go +++ b/test/integration/logs/benchmark/benchmark_test.go @@ -70,11 +70,6 @@ func BenchmarkEncoding(b *testing.B) { v, _ = strconv.Atoi(vMatch[1]) } fileSizes := map[string]int{} - b.Run("stats", func(b *testing.B) { - // Nothing to do. Use this for "go test -v - // -bench=BenchmarkLogging/.*/stats" to print - // just the statistics. - }) b.Run("printf", func(b *testing.B) { b.ResetTimer() output = 0