address comments

Signed-off-by: kerthcet <kerthcet@gmail.com>
This commit is contained in:
kerthcet 2022-07-20 10:30:08 +08:00
parent c8360913ee
commit a86bffedcf
2 changed files with 4 additions and 6 deletions

View File

@ -42,16 +42,15 @@ func TestFrameworkContract(t *testing.T) {
} }
func TestNewFramework(t *testing.T) { func TestNewFramework(t *testing.T) {
stopCh := make(<-chan struct{})
var f interface{} var f interface{}
if f, _ = runtime.NewFramework(nil, nil, stopCh); f != nil { if f, _ = runtime.NewFramework(nil, nil, nil); f != nil {
_, ok := f.(framework.Framework) _, ok := f.(framework.Framework)
assert.Equal(t, true, ok) assert.True(t, ok)
} }
} }
func TestNewCycleState(t *testing.T) { func TestNewCycleState(t *testing.T) {
var state interface{} = framework.NewCycleState() var state interface{} = framework.NewCycleState()
_, ok := state.(*framework.CycleState) _, ok := state.(*framework.CycleState)
assert.Equal(t, true, ok) assert.True(t, ok)
} }

View File

@ -28,8 +28,7 @@ var _ framework.NodeInfoLister = &nodeInfoListerContract{}
var _ framework.StorageInfoLister = &storageInfoListerContract{} var _ framework.StorageInfoLister = &storageInfoListerContract{}
var _ framework.SharedLister = &shareListerContract{} var _ framework.SharedLister = &shareListerContract{}
type nodeInfoListerContract struct { type nodeInfoListerContract struct{}
}
func (c *nodeInfoListerContract) List() ([]*framework.NodeInfo, error) { func (c *nodeInfoListerContract) List() ([]*framework.NodeInfo, error) {
return nil, nil return nil, nil