From a8b0ccc70c1848ac15d32622e33de1da5c6821f9 Mon Sep 17 00:00:00 2001 From: xuzhonghu Date: Fri, 8 Jun 2018 17:06:39 +0800 Subject: [PATCH] add ut for audit useragent --- .../apiserver/pkg/endpoints/audit_test.go | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/staging/src/k8s.io/apiserver/pkg/endpoints/audit_test.go b/staging/src/k8s.io/apiserver/pkg/endpoints/audit_test.go index 78bbe4464e4..5301f95ea18 100644 --- a/staging/src/k8s.io/apiserver/pkg/endpoints/audit_test.go +++ b/staging/src/k8s.io/apiserver/pkg/endpoints/audit_test.go @@ -63,6 +63,7 @@ func TestAudit(t *testing.T) { Other: "bla", } simpleCPrimeJSON, _ := runtime.Encode(testCodec, simpleCPrime) + userAgent := "audit-test" // event checks noRequestBody := func(i int) eventCheck { @@ -111,6 +112,16 @@ func TestAudit(t *testing.T) { return nil } } + requestUserAgentMatches := func(userAgent string) eventCheck { + return func(events []*auditinternal.Event) error { + for i := range events { + if events[i].UserAgent != userAgent { + return fmt.Errorf("expected request user agent to match %q, but got: %q", userAgent, events[i].UserAgent) + } + } + return nil + } + } for _, test := range []struct { desc string @@ -295,6 +306,8 @@ func TestAudit(t *testing.T) { t.Errorf("[%s] error creating the request: %v", test.desc, err) } + req.Header.Set("User-Agent", userAgent) + response, err := client.Do(req) if err != nil { t.Errorf("[%s] error: %v", test.desc, err) @@ -326,6 +339,10 @@ func TestAudit(t *testing.T) { t.Errorf("[%s,%d] %v", test.desc, i, err) } } + + if err := requestUserAgentMatches(userAgent)(events); err != nil { + t.Errorf("[%s] %v", test.desc, err) + } } if len(events) > 0 {