From a8c551e627aa55ae602d7c98fcd3316a652b882f Mon Sep 17 00:00:00 2001 From: Joe Betz Date: Thu, 5 Mar 2026 20:49:00 -0500 Subject: [PATCH] Fix test --- pkg/scheduler/scheduler_test.go | 31 +++++++++++++++++-------------- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/pkg/scheduler/scheduler_test.go b/pkg/scheduler/scheduler_test.go index 1a5121560a0..9e4e6f95fc4 100644 --- a/pkg/scheduler/scheduler_test.go +++ b/pkg/scheduler/scheduler_test.go @@ -1467,26 +1467,29 @@ var _ fwk.PermitPlugin = &fakePermitPlugin{} func TestNewInformerFactoryTrim(t *testing.T) { cs := fake.NewClientset() - informerFactory := NewInformerFactory(cs, 0) + pd := &v1.Pod{ObjectMeta: metav1.ObjectMeta{ Name: "test", Namespace: "default", - }, Spec: v1.PodSpec{}} - pd.SetManagedFields([]metav1.ManagedFieldsEntry{ - { - Manager: "update", - Operation: metav1.ManagedFieldsOperationApply, - APIVersion: "apps/v1", + ManagedFields: []metav1.ManagedFieldsEntry{ + { + Manager: "update", + Operation: metav1.ManagedFieldsOperationApply, + APIVersion: "apps/v1", + }, }, - }) + }} + require.NoError(t, cs.Tracker().Add(pd)) + + informerFactory := NewInformerFactory(cs, 0) lister := informerFactory.Core().V1().Pods().Lister() - informerFactory.Start(nil) - informerFactory.WaitForCacheSync(nil) - _, err := cs.CoreV1().Pods("default").Create(context.Background(), pd, metav1.CreateOptions{}) - require.NoError(t, err) - time.Sleep(time.Millisecond * 10) + ctx, cancel := context.WithCancel(context.Background()) + defer cancel() + informerFactory.Start(ctx.Done()) + informerFactory.WaitForCacheSync(ctx.Done()) + p, err := lister.Pods("default").Get("test") require.NoError(t, err) - require.Equal(t, []metav1.ManagedFieldsEntry(nil), p.GetManagedFields()) + require.Empty(t, p.GetManagedFields(), "expected managedFields to be trimmed by the transform") }