From a9582dfcbed63f7e627b8f6b04304beedbb9690f Mon Sep 17 00:00:00 2001 From: "Dr. Stefan Schimanski" Date: Thu, 24 Sep 2015 21:04:22 +0200 Subject: [PATCH] Set NodeName on daemonset pods correctly The pod template was overriding the NodeName. --- pkg/controller/controller_utils.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/controller/controller_utils.go b/pkg/controller/controller_utils.go index 1b330643c24..aa8a3cb22f1 100644 --- a/pkg/controller/controller_utils.go +++ b/pkg/controller/controller_utils.go @@ -291,12 +291,12 @@ func (r RealPodControl) createPods(nodeName, namespace string, template *api.Pod GenerateName: prefix, }, } - if len(nodeName) != 0 { - pod.Spec.NodeName = nodeName - } if err := api.Scheme.Convert(&template.Spec, &pod.Spec); err != nil { return fmt.Errorf("unable to convert pod template: %v", err) } + if len(nodeName) != 0 { + pod.Spec.NodeName = nodeName + } if labels.Set(pod.Labels).AsSelector().Empty() { return fmt.Errorf("unable to create pods, no labels") }