From f50a173bec32cd01b5f9d749c5c8a57aef732d42 Mon Sep 17 00:00:00 2001 From: Matthieu MOREL Date: Sun, 22 Sep 2024 11:57:09 +0200 Subject: [PATCH] fix: enable contains rule from testifylint in module `k8s.io/client-go` Signed-off-by: Matthieu MOREL --- .../client-go/transport/websocket/roundtripper_test.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/staging/src/k8s.io/client-go/transport/websocket/roundtripper_test.go b/staging/src/k8s.io/client-go/transport/websocket/roundtripper_test.go index c03565d1a4f..2010c73c34d 100644 --- a/staging/src/k8s.io/client-go/transport/websocket/roundtripper_test.go +++ b/staging/src/k8s.io/client-go/transport/websocket/roundtripper_test.go @@ -22,7 +22,6 @@ import ( "net/http" "net/http/httptest" "net/url" - "strings" "testing" "time" @@ -70,7 +69,7 @@ func TestWebSocketRoundTripper_RoundTripperFails(t *testing.T) { // Bad handshake means websocket server will not completely initialize. _, err := webSocketServerStreams(req, w) require.Error(t, err) - assert.True(t, strings.Contains(err.Error(), "websocket server finished before becoming ready")) + assert.ErrorContains(t, err, "websocket server finished before becoming ready") })) defer websocketServer.Close() @@ -87,8 +86,8 @@ func TestWebSocketRoundTripper_RoundTripperFails(t *testing.T) { _, err = rt.RoundTrip(req) // Ensure a "bad handshake" error is returned, since requested protocol is not supported. require.Error(t, err) - assert.True(t, strings.Contains(err.Error(), "websocket: bad handshake")) - assert.True(t, strings.Contains(err.Error(), "403 Forbidden")) + assert.ErrorContains(t, err, "websocket: bad handshake") + assert.ErrorContains(t, err, "403 Forbidden") assert.True(t, httpstream.IsUpgradeFailure(err)) }