github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-27 13:37:30 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #45441 from cjwagner/test-owners-no-default

Browse Source 
Automatic merge from submit-queue (batch tested with PRs 45508, 44258, 44126, 45441, 45320)

Removed 'default' row from test_owners.csv and Updated update_owners.py

**What this PR does / why we need it**:
Removes the 'default' row from test_owners.csv and the validation/update logic associated with it in update_owners.py.  
The 'default' row is being removed because it results in too many issues being assigned to the default test owners when issues are automatically generated.

**Release note**:

```release-note
NONE
```
/assign
This commit is contained in:
Kubernetes Submit Queue 2017-05-08 16:34:46 -07:00 committed by GitHub
commit a9ec6cbcb8
2 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hack/update_owners.py
View File

@ -86,8 +86,7 @@ def write_owners(fname, owners):
with open(fname, 'w') as f: with open(fname, 'w') as f:
out = csv.writer(f, lineterminator='\n') out = csv.writer(f, lineterminator='\n')
out.writerow(['name', 'owner', 'auto-assigned', 'sig']) out.writerow(['name', 'owner', 'auto-assigned', 'sig'])
sort_key = lambda (k, v): (k != 'DEFAULT', k) # put 'DEFAULT' first. items = sorted(owners.items())
items = sorted(owners.items(), key=sort_key)
for name, (owner, random_assignment, sig) in items: for name, (owner, random_assignment, sig) in items:
out.writerow([name, owner, int(random_assignment), sig]) out.writerow([name, owner, int(random_assignment), sig])
@ -137,7 +136,6 @@ def main():
test_names = get_test_names_from_test_history() test_names = get_test_names_from_test_history()
else: else:
test_names = get_test_names_from_local_files() test_names = get_test_names_from_local_files()
test_names.add('DEFAULT')
test_names = sorted(test_names) test_names = sorted(test_names)
owners = load_owners(OWNERS_PATH) owners = load_owners(OWNERS_PATH)

1
test/test_owners.csv
View File

@ -1,5 +1,4 @@
name,owner,auto-assigned,sig name,owner,auto-assigned,sig
DEFAULT,rmmh/spxtr/ixdy/apelisse/fejta,0,
Addon update should propagate add-on file changes,eparis,1, Addon update should propagate add-on file changes,eparis,1,
AppArmor should enforce an AppArmor profile,derekwaynecarr,0,node AppArmor should enforce an AppArmor profile,derekwaynecarr,0,node
AppArmor when running with AppArmor should enforce a permissive profile,yujuhong,1,node AppArmor when running with AppArmor should enforce a permissive profile,yujuhong,1,node

1 name owner auto-assigned sig
DEFAULT rmmh/spxtr/ixdy/apelisse/fejta 0
2 Addon update should propagate add-on file changes eparis 1
3 AppArmor should enforce an AppArmor profile derekwaynecarr 0 node
4 AppArmor when running with AppArmor should enforce a permissive profile yujuhong 1 node