From ae2597979033240481a93b65751249cf46a35d26 Mon Sep 17 00:00:00 2001 From: Adrian Moisey Date: Thu, 2 Oct 2025 21:22:10 +0200 Subject: [PATCH] Use a dedicated delete channel in HPA test This is an attempt to fix a flake --- pkg/controller/podautoscaler/horizontal_test.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/controller/podautoscaler/horizontal_test.go b/pkg/controller/podautoscaler/horizontal_test.go index 33f9548f7af..1aa8ff1a992 100644 --- a/pkg/controller/podautoscaler/horizontal_test.go +++ b/pkg/controller/podautoscaler/horizontal_test.go @@ -5192,6 +5192,7 @@ func TestMultipleHPAs(t *testing.T) { const testNamespace = "dummy-namespace" processed := make(chan string, hpaCount) + processedDeleted := make(chan string, 1) testClient := &fake.Clientset{} testScaleClient := &scalefake.FakeScaleClient{} @@ -5423,7 +5424,7 @@ func TestMultipleHPAs(t *testing.T) { testClient.AddReactor("delete", "horizontalpodautoscalers", func(action core.Action) (handled bool, ret runtime.Object, err error) { deleteAction := action.(core.DeleteAction) hpaName := deleteAction.GetName() - processed <- hpaName + processedDeleted <- hpaName return true, nil, nil }) @@ -5481,7 +5482,7 @@ func TestMultipleHPAs(t *testing.T) { // Wait for deletion to be processed select { - case deletedHPAName := <-processed: + case deletedHPAName := <-processedDeleted: assert.Equal(t, hpaName, deletedHPAName, "Expected the deleted HPA name to match") case <-time.After(5 * time.Second): t.Fatalf("Timeout waiting for HPA deletion to be processed")