From aab9cc3219fa15ea25ae1f45e2a0567a5e7b3aa1 Mon Sep 17 00:00:00 2001 From: Eric Paris Date: Fri, 20 Feb 2015 16:35:19 -0500 Subject: [PATCH] Output the inherited and non-inherited flags in the man page --- cmd/genman/gen_kubectl_man.go | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/cmd/genman/gen_kubectl_man.go b/cmd/genman/gen_kubectl_man.go index ec8f9cdbd61..5f06a651ff7 100644 --- a/cmd/genman/gen_kubectl_man.go +++ b/cmd/genman/gen_kubectl_man.go @@ -100,18 +100,18 @@ func printFlags(out *bytes.Buffer, flags *pflag.FlagSet) { } func printOptions(out *bytes.Buffer, command *cobra.Command) { - var flags *pflag.FlagSet - if command.HasFlags() { - flags = command.Flags() - } else if !command.HasParent() && command.HasPersistentFlags() { - flags = command.PersistentFlags() + flags := command.NonInheritedFlags() + if flags.HasFlags() { + fmt.Fprintf(out, "# OPTIONS\n") + printFlags(out, flags) + fmt.Fprintf(out, "\n") } - if flags == nil { - return + flags = command.InheritedFlags() + if flags.HasFlags() { + fmt.Fprintf(out, "# OPTIONS INHERITED FROM PARENT COMMANDS\n") + printFlags(out, flags) + fmt.Fprintf(out, "\n") } - fmt.Fprintf(out, "# OPTIONS\n") - printFlags(out, flags) - fmt.Fprintf(out, "\n") } func genMarkdown(command *cobra.Command, parent, docsDir string) {