mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-26 05:03:09 +00:00
Merge pull request #65901 from jbartosik/hpa-improv-refactor-replica-calc-test
Automatic merge from submit-queue (batch tested with PRs 66175, 66324, 65828, 65901, 66350). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Hpa improv refactor replica calc test **What this PR does / why we need it**: prepareTestClient generates 4 fake clients, using replicaCalcTestCase object. This PR extracts a separate helper for generating each fake independently. **Which issue(s) this PR fixes** **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
This commit is contained in:
commit
ab00c609ee
@ -87,8 +87,7 @@ const (
|
|||||||
numContainersPerPod = 2
|
numContainersPerPod = 2
|
||||||
)
|
)
|
||||||
|
|
||||||
func (tc *replicaCalcTestCase) prepareTestClient(t *testing.T) (*fake.Clientset, *metricsfake.Clientset, *cmfake.FakeCustomMetricsClient, *emfake.FakeExternalMetricsClient) {
|
func (tc *replicaCalcTestCase) prepareTestClientSet() *fake.Clientset {
|
||||||
|
|
||||||
fakeClient := &fake.Clientset{}
|
fakeClient := &fake.Clientset{}
|
||||||
fakeClient.AddReactor("list", "pods", func(action core.Action) (handled bool, ret runtime.Object, err error) {
|
fakeClient.AddReactor("list", "pods", func(action core.Action) (handled bool, ret runtime.Object, err error) {
|
||||||
obj := &v1.PodList{}
|
obj := &v1.PodList{}
|
||||||
@ -145,7 +144,10 @@ func (tc *replicaCalcTestCase) prepareTestClient(t *testing.T) (*fake.Clientset,
|
|||||||
}
|
}
|
||||||
return true, obj, nil
|
return true, obj, nil
|
||||||
})
|
})
|
||||||
|
return fakeClient
|
||||||
|
}
|
||||||
|
|
||||||
|
func (tc *replicaCalcTestCase) prepareTestMetricsClient() *metricsfake.Clientset {
|
||||||
fakeMetricsClient := &metricsfake.Clientset{}
|
fakeMetricsClient := &metricsfake.Clientset{}
|
||||||
// NB: we have to sound like Gollum due to gengo's inability to handle already-plural resource names
|
// NB: we have to sound like Gollum due to gengo's inability to handle already-plural resource names
|
||||||
fakeMetricsClient.AddReactor("list", "pods", func(action core.Action) (handled bool, ret runtime.Object, err error) {
|
fakeMetricsClient.AddReactor("list", "pods", func(action core.Action) (handled bool, ret runtime.Object, err error) {
|
||||||
@ -185,7 +187,10 @@ func (tc *replicaCalcTestCase) prepareTestClient(t *testing.T) (*fake.Clientset,
|
|||||||
|
|
||||||
return true, nil, fmt.Errorf("no pod resource metrics specified in test client")
|
return true, nil, fmt.Errorf("no pod resource metrics specified in test client")
|
||||||
})
|
})
|
||||||
|
return fakeMetricsClient
|
||||||
|
}
|
||||||
|
|
||||||
|
func (tc *replicaCalcTestCase) prepareTestCMClient(t *testing.T) *cmfake.FakeCustomMetricsClient {
|
||||||
fakeCMClient := &cmfake.FakeCustomMetricsClient{}
|
fakeCMClient := &cmfake.FakeCustomMetricsClient{}
|
||||||
fakeCMClient.AddReactor("get", "*", func(action core.Action) (handled bool, ret runtime.Object, err error) {
|
fakeCMClient.AddReactor("get", "*", func(action core.Action) (handled bool, ret runtime.Object, err error) {
|
||||||
getForAction, wasGetFor := action.(cmfake.GetForAction)
|
getForAction, wasGetFor := action.(cmfake.GetForAction)
|
||||||
@ -250,7 +255,10 @@ func (tc *replicaCalcTestCase) prepareTestClient(t *testing.T) (*fake.Clientset,
|
|||||||
|
|
||||||
return true, metrics, nil
|
return true, metrics, nil
|
||||||
})
|
})
|
||||||
|
return fakeCMClient
|
||||||
|
}
|
||||||
|
|
||||||
|
func (tc *replicaCalcTestCase) prepareTestEMClient(t *testing.T) *emfake.FakeExternalMetricsClient {
|
||||||
fakeEMClient := &emfake.FakeExternalMetricsClient{}
|
fakeEMClient := &emfake.FakeExternalMetricsClient{}
|
||||||
fakeEMClient.AddReactor("list", "*", func(action core.Action) (handled bool, ret runtime.Object, err error) {
|
fakeEMClient.AddReactor("list", "*", func(action core.Action) (handled bool, ret runtime.Object, err error) {
|
||||||
listAction, wasList := action.(core.ListAction)
|
listAction, wasList := action.(core.ListAction)
|
||||||
@ -283,7 +291,14 @@ func (tc *replicaCalcTestCase) prepareTestClient(t *testing.T) (*fake.Clientset,
|
|||||||
|
|
||||||
return true, &metrics, nil
|
return true, &metrics, nil
|
||||||
})
|
})
|
||||||
|
return fakeEMClient
|
||||||
|
}
|
||||||
|
|
||||||
|
func (tc *replicaCalcTestCase) prepareTestClient(t *testing.T) (*fake.Clientset, *metricsfake.Clientset, *cmfake.FakeCustomMetricsClient, *emfake.FakeExternalMetricsClient) {
|
||||||
|
fakeClient := tc.prepareTestClientSet()
|
||||||
|
fakeMetricsClient := tc.prepareTestMetricsClient()
|
||||||
|
fakeCMClient := tc.prepareTestCMClient(t)
|
||||||
|
fakeEMClient := tc.prepareTestEMClient(t)
|
||||||
return fakeClient, fakeMetricsClient, fakeCMClient, fakeEMClient
|
return fakeClient, fakeMetricsClient, fakeCMClient, fakeEMClient
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user