github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-22 11:21:47 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #74538 from MrHohn/e2e-service-latencies-flake

Browse Source 
[e2e] Add acceptableFailureRatio to service latency test
This commit is contained in:
Kubernetes Prow Robot 2019-02-28 20:36:17 -08:00 committed by GitHub
commit ac0a946d3e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
test/e2e/network/service_latency.go
View File

@ -71,6 +71,9 @@ var _ = SIGDescribe("Service endpoints latency", func() {
totalTrials = 200 totalTrials = 200
parallelTrials = 15 parallelTrials = 15
minSampleSize = 100 minSampleSize = 100
// Acceptable failure ratio for getting service latencies.
acceptableFailureRatio = .05
) )
// Turn off rate limiting--it interferes with our measurements. // Turn off rate limiting--it interferes with our measurements.
@ -79,7 +82,7 @@ var _ = SIGDescribe("Service endpoints latency", func() {
defer func() { f.ClientSet.CoreV1().RESTClient().(*restclient.RESTClient).Throttle = oldThrottle }() defer func() { f.ClientSet.CoreV1().RESTClient().(*restclient.RESTClient).Throttle = oldThrottle }()
failing := sets.NewString() failing := sets.NewString()
d, err := runServiceLatencies(f, parallelTrials, totalTrials) d, err := runServiceLatencies(f, parallelTrials, totalTrials, acceptableFailureRatio)
if err != nil { if err != nil {
failing.Insert(fmt.Sprintf("Not all RC/pod/service trials succeeded: %v", err)) failing.Insert(fmt.Sprintf("Not all RC/pod/service trials succeeded: %v", err))
} }
@ -123,7 +126,7 @@ var _ = SIGDescribe("Service endpoints latency", func() {
}) })
}) })
func runServiceLatencies(f *framework.Framework, inParallel, total int) (output []time.Duration, err error) { func runServiceLatencies(f *framework.Framework, inParallel, total int, acceptableFailureRatio float32) (output []time.Duration, err error) {
cfg := testutils.RCConfig{ cfg := testutils.RCConfig{
Client: f.ClientSet, Client: f.ClientSet,
InternalClient: f.InternalClientset, InternalClient: f.InternalClientset,
@ -180,7 +183,11 @@ func runServiceLatencies(f *framework.Framework, inParallel, total int) (output
} }
} }
if errCount != 0 { if errCount != 0 {
return output, fmt.Errorf("got %v errors", errCount) framework.Logf("Got %d errors out of %d tries", errCount, total)
errRatio := float32(errCount) / float32(total)
if errRatio > acceptableFailureRatio {
return output, fmt.Errorf("error ratio %g is higher than the acceptable ratio %g", errRatio, acceptableFailureRatio)
}
} }
return output, nil return output, nil
} }