Remove reflect.DeepEqual for defaultpreemption, helper, and imagelocality package

This commit is contained in:
drfish
2021-02-09 23:37:36 +08:00
parent 6389c13960
commit ac0b034b02
6 changed files with 15 additions and 14 deletions

View File

@@ -35,6 +35,7 @@ go_test(
"//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
"//staging/src/k8s.io/client-go/informers:go_default_library",
"//staging/src/k8s.io/client-go/kubernetes/fake:go_default_library",
"//vendor/github.com/google/go-cmp/cmp:go_default_library",
],
)

View File

@@ -18,9 +18,9 @@ package helper
import (
"fmt"
"reflect"
"testing"
"github.com/google/go-cmp/cmp"
"k8s.io/kubernetes/pkg/scheduler/framework"
)
@@ -76,8 +76,8 @@ func TestDefaultNormalizeScore(t *testing.T) {
}
DefaultNormalizeScore(framework.MaxNodeScore, test.reverse, scores)
if !reflect.DeepEqual(scores, expectedScores) {
t.Errorf("expected %v, got %v", expectedScores, scores)
if diff := cmp.Diff(expectedScores, scores); diff != "" {
t.Errorf("Unexpected scores (-want, +got):\n%s", diff)
}
})
}

View File

@@ -18,10 +18,10 @@ package helper
import (
"fmt"
"reflect"
"testing"
"time"
"github.com/google/go-cmp/cmp"
v1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/informers"
@@ -97,8 +97,8 @@ func TestGetPodServices(t *testing.T) {
get, err := GetPodServices(fakeInformerFactory.Core().V1().Services().Lister(), test.pod)
if err != nil {
t.Errorf("Error from GetPodServices: %v", err)
} else if !reflect.DeepEqual(get, test.expect) {
t.Errorf("Expect services %v, but got %v", test.expect, get)
} else if diff := cmp.Diff(test.expect, get); diff != "" {
t.Errorf("Unexpected services (-want, +got):\n%s", diff)
}
})
}