github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-31 07:20:13 +00:00
Code Issues Projects Releases Wiki Activity

fix: address reviews on e2e

Browse Source
This commit is contained in:
Kensei Nakada 2024-10-31 18:43:22 +09:00
parent 08e8403e2e
commit ac5aacc5f6
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/e2e/scheduling/preemption.go
View File

@ -307,18 +307,17 @@ var _ = SIGDescribe("SchedulerPreemption", framework.WithSerial(), func() {
}) })
/* /*
Release: v1.23 Release: v1.32
Testname: Scheduler runs the preemption with various priority classes expectedly Testname: Scheduler runs the preemption with various priority classes expectedly
Description: When there are Pods with various priority classes running the preemption, Description: When there are Pods with various priority classes running the preemption,
the scheduler must prioritize the Pods with the higher priority class. the scheduler must prioritize the Pods with the higher priority class.
*/ */
framework.It("validates various priority Pods preempt expectedly with the async preemption", feature.SchedulerAsyncPreemption, func(ctx context.Context) { framework.It("validates various priority Pods preempt expectedly with the async preemption", feature.SchedulerAsyncPreemption, func(ctx context.Context) {
var podRes v1.ResourceList var podRes v1.ResourceList
// Create two pods per node that uses a lot of the node's resources. // Create 10 pods per node that will eat up all the node's resources.
ginkgo.By("Create 10 low-priority pods on each node.") ginkgo.By("Create 10 low-priority pods on each node.")
lowPriorityPods := make([]*v1.Pod, 0, 10*len(nodeList.Items)) lowPriorityPods := make([]*v1.Pod, 0, 10*len(nodeList.Items))
// Create pods in the cluster. // Create pods in the cluster.
// One of them has low priority, making it the victim for preemption.
for i, node := range nodeList.Items { for i, node := range nodeList.Items {
// Update each node to advertise 3 available extended resources // Update each node to advertise 3 available extended resources
nodeCopy := node.DeepCopy() nodeCopy := node.DeepCopy()
@ -329,7 +328,7 @@ var _ = SIGDescribe("SchedulerPreemption", framework.WithSerial(), func() {
// Create 10 low priority pods on each node, which will use up 10/10 of the node's resources. // Create 10 low priority pods on each node, which will use up 10/10 of the node's resources.
for j := 0; j < 10; j++ { for j := 0; j < 10; j++ {
// Request 2 of the available resources for the victim pods // Request 1 of the available resources for the victim pods
podRes = v1.ResourceList{} podRes = v1.ResourceList{}
podRes[testExtendedResource] = resource.MustParse("1") podRes[testExtendedResource] = resource.MustParse("1")
pausePod := createPausePod(ctx, f, pausePodConfig{ pausePod := createPausePod(ctx, f, pausePodConfig{
@ -426,7 +425,7 @@ var _ = SIGDescribe("SchedulerPreemption", framework.WithSerial(), func() {
if err != nil { if err != nil {
return false, err return false, err
} }
return highPod.Status.NominatedNodeName != "", err return highPod.Status.NominatedNodeName != "", nil
})) }))
} }