From ac8abb7ac26ea7f95a6fc5ffb25d45b83b877e78 Mon Sep 17 00:00:00 2001 From: Maryam Labib Date: Thu, 9 Jul 2020 20:05:15 -0700 Subject: [PATCH] Resolves staticcheck failures for component-base/metrics --- hack/.staticcheck_failures | 1 - staging/src/k8s.io/component-base/metrics/metric.go | 3 --- staging/src/k8s.io/component-base/metrics/processstarttime.go | 2 +- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/hack/.staticcheck_failures b/hack/.staticcheck_failures index 94549364320..500957d243f 100644 --- a/hack/.staticcheck_failures +++ b/hack/.staticcheck_failures @@ -70,7 +70,6 @@ vendor/k8s.io/client-go/rest/watch vendor/k8s.io/client-go/restmapper vendor/k8s.io/client-go/tools/leaderelection vendor/k8s.io/client-go/transport -vendor/k8s.io/component-base/metrics vendor/k8s.io/kubectl/pkg/cmd/get vendor/k8s.io/kubectl/pkg/cmd/scale vendor/k8s.io/kubectl/pkg/cmd/testing diff --git a/staging/src/k8s.io/component-base/metrics/metric.go b/staging/src/k8s.io/component-base/metrics/metric.go index 1cf788f8c3f..bb1f6962709 100644 --- a/staging/src/k8s.io/component-base/metrics/metric.go +++ b/staging/src/k8s.io/component-base/metrics/metric.go @@ -188,9 +188,6 @@ func (c *selfCollector) Collect(ch chan<- prometheus.Metric) { // no-op vecs for convenience var noopCounterVec = &prometheus.CounterVec{} var noopHistogramVec = &prometheus.HistogramVec{} - -// lint:ignore U1000 Keep it for future use -var noopSummaryVec = &prometheus.SummaryVec{} var noopGaugeVec = &prometheus.GaugeVec{} var noopObserverVec = &noopObserverVector{} diff --git a/staging/src/k8s.io/component-base/metrics/processstarttime.go b/staging/src/k8s.io/component-base/metrics/processstarttime.go index b20516ec9ca..0fbbe2b47bc 100644 --- a/staging/src/k8s.io/component-base/metrics/processstarttime.go +++ b/staging/src/k8s.io/component-base/metrics/processstarttime.go @@ -54,7 +54,7 @@ func getProcessStart() (float64, error) { return 0, err } - if stat, err := p.NewStat(); err == nil { + if stat, err := p.Stat(); err == nil { return stat.StartTime() } return 0, err