github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-31 07:20:13 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #91520 from weijiehu/azureconfig

Browse Source 
Improves unittest CC for azure_config
This commit is contained in:
Kubernetes Prow Robot 2020-05-30 02:57:52 -07:00 committed by GitHub
commit acaa9eaca1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 104 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

112
staging/src/k8s.io/legacy-cloud-providers/azure/azure_config_test.go
View File

@ -90,6 +90,7 @@ func getTestCloudConfigTypeMergeConfigExpected() *Config {
func TestGetConfigFromSecret(t *testing.T) {
emptyConfig := &Config{}
badConfig := &Config{ResourceGroup: "DuplicateColumnsIncloud-config"}
tests := []struct {
name string
existingConfig *Config
@ -129,6 +130,108 @@ func TestGetConfigFromSecret(t *testing.T) {
secretConfig: emptyConfig,
expectErr: true,
},
{
name: "Error should be reported when it failed to parse Azure cloud-config",
existingConfig: getTestCloudConfigTypeMergeConfig(),
secretConfig: badConfig,
expectErr: true,
},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
az := &Cloud{
KubeClient: fakeclient.NewSimpleClientset(),
}
if test.existingConfig != nil {
az.Config = *test.existingConfig
}
if test.secretConfig != nil {
secret := &v1.Secret{
Type: v1.SecretTypeOpaque,
ObjectMeta: metav1.ObjectMeta{
Name: "azure-cloud-provider",
Namespace: "kube-system",
},
}
if test.secretConfig != emptyConfig && test.secretConfig != badConfig {
secretData, err := yaml.Marshal(test.secretConfig)
assert.NoError(t, err, test.name)
secret.Data = map[string][]byte{
"cloud-config": secretData,
}
}
if test.secretConfig == badConfig {
secret.Data = map[string][]byte{"cloud-config": []byte(`unknown: "hello",unknown: "hello"`)}
}
_, err := az.KubeClient.CoreV1().Secrets(cloudConfigNamespace).Create(context.TODO(), secret, metav1.CreateOptions{})
assert.NoError(t, err, test.name)
}
real, err := az.getConfigFromSecret()
if test.expectErr {
assert.Error(t, err, test.name)
return
}
assert.NoError(t, err, test.name)
assert.Equal(t, test.expected, real, test.name)
})
}
}
func TestInitializeCloudFromSecret(t *testing.T) {
emptyConfig := &Config{}
unknownConfigTypeConfig := getTestConfig()
unknownConfigTypeConfig.CloudConfigType = "UnknownConfigType"
tests := []struct {
name string
existingConfig *Config
secretConfig *Config
expected *Config
expectErr bool
}{
{
name: "Azure config shouldn't be override when cloud config type is file",
existingConfig: &Config{
ResourceGroup: "ResourceGroup1",
CloudConfigType: cloudConfigTypeFile,
},
secretConfig: getTestConfig(),
expected: nil,
},
{
name: "Azure config shouldn't be override when cloud config type is unknown",
existingConfig: &Config{
ResourceGroup: "ResourceGroup1",
CloudConfigType: "UnknownConfigType",
},
secretConfig: unknownConfigTypeConfig,
expected: nil,
},
{
name: "Azure config should be override when cloud config type is secret",
existingConfig: getTestCloudConfigTypeSecretConfig(),
secretConfig: getTestConfig(),
expected: getTestConfig(),
},
{
name: "Azure config should be override when cloud config type is merge",
existingConfig: getTestCloudConfigTypeMergeConfig(),
secretConfig: getTestConfig(),
expected: getTestCloudConfigTypeMergeConfigExpected(),
},
{
name: "Error should be reported when secret doesn't exists",
existingConfig: getTestCloudConfigTypeMergeConfig(),
expectErr: true,
},
{
name: "Error should be reported when secret exists but cloud-config data is not provided",
existingConfig: getTestCloudConfigTypeMergeConfig(),
secretConfig: emptyConfig,
expectErr: true,
},
}
for _, test := range tests {
@ -158,14 +261,7 @@ func TestGetConfigFromSecret(t *testing.T) {
assert.NoError(t, err, test.name)
}
real, err := az.getConfigFromSecret()
if test.expectErr {
assert.Error(t, err, test.name)
return
}
assert.NoError(t, err, test.name)
assert.Equal(t, test.expected, real, test.name)
az.InitializeCloudFromSecret()
})
}
}