github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-27 13:37:30 +00:00
Code Issues Projects Releases Wiki Activity

Fix regression pruning array fields with x-kubernetes-preserve-unknown-fields: true

Browse Source
This commit is contained in:
Jordan Liggitt 2022-01-21 14:06:49 -05:00
parent e7e58de49f
commit acb8d4ed20
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/schema/pruning/algorithm.go
View File

@ -189,7 +189,7 @@ func skipPrune(x interface{}, s *structuralschema.Structural, opts *PruneOptions
case []interface{}:
for i, v := range x {
opts.appendIndex(i)
prune(v, s.Items, opts)
skipPrune(v, s.Items, opts)
opts.parentPath = opts.parentPath[:origPathLen]
}
default:

10
staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/schema/pruning/algorithm_test.go
View File

@ -88,7 +88,8 @@ func TestPrune(t *testing.T) {
"unspecified": "bar",
"unspecifiedObject": {"unspecified": "bar"},
"pruning": {"unspecified": "bar"},
"preserving": {"unspecified": "bar"}
"preserving": {"unspecified": "bar"},
"preservingUnknownType": [{"foo":true},{"bar":true}]
},
"preservingAdditionalPropertiesNotInheritingXPreserveUnknownFields": {
"foo": {
@ -129,6 +130,10 @@ func TestPrune(t *testing.T) {
Generic: structuralschema.Generic{Type: "object"},
Extensions: structuralschema.Extensions{XPreserveUnknownFields: true},
},
"preservingUnknownType": {
Generic: structuralschema.Generic{Type: ""},
Extensions: structuralschema.Extensions{XPreserveUnknownFields: true},
},
"pruning": {
Generic: structuralschema.Generic{Type: "object"},
},
@ -177,7 +182,8 @@ func TestPrune(t *testing.T) {
"unspecified": "bar",
"unspecifiedObject": {"unspecified": "bar"},
"pruning": {},
"preserving": {"unspecified": "bar"}
"preserving": {"unspecified": "bar"},
"preservingUnknownType": [{"foo":true},{"bar":true}]
},
"preservingAdditionalPropertiesNotInheritingXPreserveUnknownFields": {
"foo": {