From ace8386d137d871eeac671865161597e8982ec2e Mon Sep 17 00:00:00 2001 From: Maciej Szulik Date: Wed, 22 Aug 2018 13:56:57 +0200 Subject: [PATCH] Get rid of argsLenAtDash in create job --- pkg/kubectl/cmd/create/create_job.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/pkg/kubectl/cmd/create/create_job.go b/pkg/kubectl/cmd/create/create_job.go index 68fe5b94ac6..b0665ee2731 100644 --- a/pkg/kubectl/cmd/create/create_job.go +++ b/pkg/kubectl/cmd/create/create_job.go @@ -85,8 +85,7 @@ func NewCmdCreateJob(f cmdutil.Factory, ioStreams genericclioptions.IOStreams) * Long: jobLong, Example: jobExample, Run: func(cmd *cobra.Command, args []string) { - argsLenAtDash := cmd.ArgsLenAtDash() - cmdutil.CheckErr(o.Complete(f, cmd, args, argsLenAtDash)) + cmdutil.CheckErr(o.Complete(f, cmd, args)) cmdutil.CheckErr(o.Validate()) cmdutil.CheckErr(o.Run()) }, @@ -103,11 +102,12 @@ func NewCmdCreateJob(f cmdutil.Factory, ioStreams genericclioptions.IOStreams) * return cmd } -func (o *CreateJobOptions) Complete(f cmdutil.Factory, cmd *cobra.Command, args []string, argsLenAtDash int) error { - if len(args) == 0 || argsLenAtDash == 0 { - return cmdutil.UsageErrorf(cmd, "NAME is required") +func (o *CreateJobOptions) Complete(f cmdutil.Factory, cmd *cobra.Command, args []string) error { + name, err := NameFromCommandArgs(cmd, args) + if err != nil { + return err } - o.Name = args[0] + o.Name = name if len(args) > 1 { o.Command = args[1:] }