github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-26 21:17:23 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #50406 from alrs/fix-vsphere-volume-dropped-errors

Browse Source 
Automatic merge from submit-queue

Fix dropped errors in vsphere_volume

**What this PR does / why we need it**: Error variables are being assigned in the vsphere_volume tests, but their values are being ignored.

**Release note**:

```release-note NONE
```
This commit is contained in:
Kubernetes Submit Queue 2017-08-14 18:23:51 -07:00 committed by GitHub
commit acf7b5715c
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/volume/vsphere_volume/vsphere_volume_test.go
View File

@ -153,6 +153,9 @@ func TestPlugin(t *testing.T) {
PersistentVolumeReclaimPolicy: v1.PersistentVolumeReclaimDelete, PersistentVolumeReclaimPolicy: v1.PersistentVolumeReclaimDelete,
} }
provisioner, err := plug.(*vsphereVolumePlugin).newProvisionerInternal(options, &fakePDManager{}) provisioner, err := plug.(*vsphereVolumePlugin).newProvisionerInternal(options, &fakePDManager{})
if err != nil {
t.Errorf("newProvisionerInternal() failed: %v", err)
}
persistentSpec, err := provisioner.Provision() persistentSpec, err := provisioner.Provision()
if err != nil { if err != nil {
t.Errorf("Provision() failed: %v", err) t.Errorf("Provision() failed: %v", err)
@ -177,6 +180,9 @@ func TestPlugin(t *testing.T) {
PersistentVolume: persistentSpec, PersistentVolume: persistentSpec,
} }
deleter, err := plug.(*vsphereVolumePlugin).newDeleterInternal(volSpec, &fakePDManager{}) deleter, err := plug.(*vsphereVolumePlugin).newDeleterInternal(volSpec, &fakePDManager{})
if err != nil {
t.Errorf("newDeleterInternal() failed: %v", err)
}
err = deleter.Delete() err = deleter.Delete()
if err != nil { if err != nil {
t.Errorf("Deleter() failed: %v", err) t.Errorf("Deleter() failed: %v", err)