github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-25 20:53:33 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #78675 from hex108/bug_fix

Browse Source 
Fix error case for ExtractFieldPathAsString
This commit is contained in:
Kubernetes Prow Robot 2019-07-30 03:35:04 -07:00 committed by GitHub
commit acfeb8a05e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/fieldpath/fieldpath.go
View File

@ -46,7 +46,7 @@ func FormatMap(m map[string]string) (fmtStr string) {
func ExtractFieldPathAsString(obj interface{}, fieldPath string) (string, error) { func ExtractFieldPathAsString(obj interface{}, fieldPath string) (string, error) {
accessor, err := meta.Accessor(obj) accessor, err := meta.Accessor(obj)
if err != nil { if err != nil {
return "", nil return "", err
} }
if path, subscript, ok := SplitMaybeSubscriptedPath(fieldPath); ok { if path, subscript, ok := SplitMaybeSubscriptedPath(fieldPath); ok {

7
pkg/fieldpath/fieldpath_test.go
View File

@ -33,9 +33,10 @@ func TestExtractFieldPathAsString(t *testing.T) {
expectedMessageFragment string expectedMessageFragment string
}{ }{
{ {
name: "not an API object", name: "not an API object",
fieldPath: "metadata.name", fieldPath: "metadata.name",
obj: "", obj: "",
expectedMessageFragment: "object does not implement the Object interfaces",
}, },
{ {
name: "ok - namespace", name: "ok - namespace",