github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-04 01:40:07 +00:00
Code Issues Projects Releases Wiki Activity

remove redundant deleting endpoint explicitly in endpoint controller

Browse Source
This commit is contained in:
hzxuzhonghu 2018-01-02 20:35:30 +08:00
parent da9a4d5da9
commit ad06747027
1 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/controller/endpoint/endpoints_controller.go
View File

@ -394,15 +394,7 @@ func (e *EndpointController) syncService(key string) error {
} }
service, err := e.serviceLister.Services(namespace).Get(name) service, err := e.serviceLister.Services(namespace).Get(name)
if err != nil { if err != nil {
// Delete the corresponding endpoint, as the service has been deleted. // Service has been deleted. So no need to do any more operations.
// TODO: Please note that this will delete an endpoint when a
// service is deleted. However, if we're down at the time when
// the service is deleted, we will miss that deletion, so this
// doesn't completely solve the problem. See #6877.
err = e.client.CoreV1().Endpoints(namespace).Delete(name, nil)
if err != nil && !errors.IsNotFound(err) {
return err
}
return nil return nil
} }